Prevent duplication of cells while filtering #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain elements in an 'ember-collection' based list is rendered more than once, when filtering is performed on the list. I noticed this issue when i tried to use 'ember-collection' inside 'ember-power-select'. Below images depict this issue,
List showing duplicates
Duplicates in DOM
I traced down the root cause of this issue being related to presence of 'cellMap', which seems to be a lookup to check if the cell is already being rendered or not. Avoiding this lookup when inserting new items, resolve the issue.