Support Ember CLI >= 3.26.0 and match injected script element by all supported Ember CLI versions with same RegExp #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
changed the title
jelhan
approved these changes
May 6, 2021
There was a problem hiding this comment.
Thanks a lot for fixing this.
Please excuse that it has taken that long for me to reply. As documented in #200 I lost trust in the CI pipeline. I wanted to get that fixed again at least somehow to verify that the new regular expression is working for all supported Ember CLI versions.
#202 fixes the CI setup. I merged this one it. The CI is still unstable for Ember CLI 3.8. Therefore it is not merged yet. But it has proven that this fix is correct. 🎉
|
Released as v2.0.0-4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #199