Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ChartJS 3.5 #138

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

walter
Copy link
Contributor

@walter walter commented Oct 11, 2021

Closes #127

Supersedes PR #136

See previous PR for background, but basically only updates ChartJS rather than also trying to sort out the chart-chartjs-financial dependency. That will be dealt with in a separate PR.

@raheed-web
Copy link

@aomran if this PR looks good would you be able to merge it? The project I am working on would really benefit from the new APIs available in [email protected]

@nanderss
Copy link

@aomran We would need this one as well, could this get merged?

@TonnyBiDa
Copy link

@aomran Could this get merged?

@ntnz
Copy link

ntnz commented Jun 16, 2022

@aomran :)

@ixxvivxxi
Copy link

Is there any hope that this PR will merge?

@RobbieTheWagner
Copy link
Member

LGTM!

@RobbieTheWagner RobbieTheWagner merged commit 43ec6e5 into adopted-ember-addons:master Feb 15, 2023
@RobbieTheWagner
Copy link
Member

Does anyone know if there are breaking changes in Chart.js that we need to address in this addon? Test coverage seems light and just does assert.dom('canvas').exists(); so unsure if this breaks anything.

@Frank3K
Copy link

Frank3K commented Feb 15, 2023

One thing that I disliked about Chart 2 was that it required a global moment to be available. Since version 3 that is not needed anymore; you can now drop in an available time library as an adapter.

Not sure if that affects ember-cli-chart / its tests. More info about the changes is on https://www.chartjs.org/docs/latest/migration/v3-migration.html#setup-and-installation.

@heshamnimri
Copy link

Since this has not been released how can I have this update available in my repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart.js 3.0 support
10 participants