-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ChartJS 3.5 #138
Update to ChartJS 3.5 #138
Conversation
@aomran if this PR looks good would you be able to merge it? The project I am working on would really benefit from the new APIs available in |
@aomran We would need this one as well, could this get merged? |
@aomran Could this get merged? |
@aomran :) |
Is there any hope that this PR will merge? |
LGTM! |
Does anyone know if there are breaking changes in Chart.js that we need to address in this addon? Test coverage seems light and just does |
One thing that I disliked about Chart 2 was that it required a global moment to be available. Since version 3 that is not needed anymore; you can now drop in an available time library as an adapter. Not sure if that affects ember-cli-chart / its tests. More info about the changes is on https://www.chartjs.org/docs/latest/migration/v3-migration.html#setup-and-installation. |
Since this has not been released how can I have this update available in my repo? |
Closes #127
Supersedes PR #136
See previous PR for background, but basically only updates ChartJS rather than also trying to sort out the
chart-chartjs-financial
dependency. That will be dealt with in a separate PR.