BUG: Reproduce modifier recalculation issue #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are a starting point to discuss a strange behavior I only see with Changesets and Modifiers.
My best understanding is that the interaction between changesets and modifiers causes them to recalculate even when unrelated properties of the changeset are modified.
This might seem expected at first till you realize that this behavior does not happen with helpers and also with non-changeset objects.
This PR had to add
ember-modifier
andember-functions-as-modifiers-polyfill
addons to show the expected use case for these two modifier addons.The simplest code example I have is this: