Merge pull request #698 from adopted-ember-addons/helper-types

Provide types for helpers named exports for .gts support
adopted-ember-addons · Nov 9, 2024 · 6219bca · 6219bca
2 parents 4f1c74e + 72d6317
commit 6219bca
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/.github/workflows/plan-release.yml b/.github/workflows/plan-release.yml
@@ -56,8 +56,6 @@ jobs:
         with:
           node-version: 18
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - run: pnpm install --frozen-lockfile
       - name: "Generate Explanation and Prep Changelogs"
         id: explanation

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -50,8 +50,6 @@ jobs:
           # This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
           registry-url: 'https://registry.npmjs.org'
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - run: pnpm install --frozen-lockfile
       - name: npm publish
         run: pnpm release-plan publish

diff --git a/ember-changeset/.npmignore b/ember-changeset/.npmignore
@@ -19,7 +19,6 @@
 /.template-lintrc.js
 /.travis.yml
 /.watchmanconfig
-/CODE_OF_CONDUCT.md
 /CONTRIBUTING.md
 /ember-cli-build.js
 /testem.js

diff --git a/ember-changeset/index.d.ts b/ember-changeset/index.d.ts
@@ -1,4 +1,5 @@
 import { BufferedChangeset } from 'validated-changeset';
+import type { HelperLike } from '@glint/template';
 
 type BufferedChangesetConstructorParameters = ConstructorParameters<typeof BufferedChangeset>;
 
@@ -14,3 +15,17 @@ type changesetFunctionsParameters = [
 export class EmberChangeset extends BufferedChangeset {}
 export function changeset(...args: changesetFunctionsParameters): EmberChangeset;
 export function Changeset(...args: changesetFunctionsParameters): EmberChangeset;
+
+type changesetGet = HelperLike<{
+  Args: {
+    Positional: [changeset: BufferedChangeset | EmberChangeset, fieldPath: string];
+  };
+  Return: unknown;
+}>;
+
+type changesetSet = HelperLike<{
+  Args: {
+    Positional: [changeset: BufferedChangeset | EmberChangeset, fieldPath: string];
+  };
+  Return: (value: unknown) => void;
+}>;