Declare peer dependency on @ember/string for compatibility with Ember >= 5

[jelhan]

Declaring peer dependency on @ember/string to make the addon compatible with Ember >= 5.

[SergeAstapov]

I guess, this needs to be in separate PR.

@jelhan mind if we keep volta for now as is? I intentionally kept it without changes until v2 conversion is completed

[jelhan]

The issue was that the existing lock file was not compatible with the specified NPM version. It was in v2 format not supported by NPM v6. Pinning to a recent version and regenerating lock file was the easiest solution.

[jelhan]

CI was failing. Likely an incompatibility caused by very outdated node 12 used in CI. I restored the original pinned versions of Node and NPM and regenerated the lockfile with that version.

[jelhan]

Do you consider adding an additional peer dependency as a breaking change? If so, we may want to do other breaking changes in the same release.

Potential breaking changes which we may want to ship are

• Drop support for node < 18
• Drop support for Ember < 4.12
• Drop support for ember-get-config < 2

[SergeAstapov]

@jelhan as this addon already depends on ember-auto-import, the conversion to v2 won't be a breaking change itself.
and as a result, v2 addons do not need to declare supported node.js versions, hence updagin Node.js in CI would be non-breaking change for that reason.

Was thinking about dropping support for older Ember versiosn to simplify CI in case if I can't get CI work fine with those old versions.

Considering this change, sounds like we should plan new major as a result of many updates discussed here.

[SergeAstapov]

@jelhan as for CI failures, that's a problem for v5 and up, I haven't get to fixing it in this repo as fixed it in only in ember-changeset.

@jelhan if you'd like to help, I planned to have a separate PR just to bring CI to green state without any major/breaking changes

[jelhan]

@jelhan as for CI failures, that's a problem for v5 and up, I haven't get to fixing it in this repo as fixed it in only in ember-changeset.

Got it.

@jelhan if you'd like to help, I planned to have a separate PR just to bring CI to green state without any major/breaking changes

I have only limited open source time available. If you are already at it, that's great. We can park this PR until CI is fixed.