-
Notifications
You must be signed in to change notification settings - Fork 229
chore: remove button from the changeset front matter for clear button changes #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Name | Type |
---|---|
@spectrum-web-components/clear-button | Minor |
@spectrum-web-components/button | Minor |
@spectrum-web-components/styles | Minor |
@spectrum-web-components/bundle | Minor |
@spectrum-web-components/action-bar | Minor |
@spectrum-web-components/action-button | Minor |
@spectrum-web-components/alert-banner | Minor |
@spectrum-web-components/alert-dialog | Minor |
@spectrum-web-components/button-group | Minor |
@spectrum-web-components/coachmark | Minor |
@spectrum-web-components/dialog | Minor |
@spectrum-web-components/infield-button | Minor |
@spectrum-web-components/picker-button | Minor |
@spectrum-web-components/picker | Minor |
@spectrum-web-components/search | Minor |
@spectrum-web-components/tags | Minor |
@spectrum-web-components/toast | Minor |
example-project-rollup | Patch |
example-project-webpack | Patch |
@spectrum-web-components/card | Minor |
@spectrum-web-components/illustrated-message | Minor |
@spectrum-web-components/custom-vars-viewer | Minor |
@spectrum-web-components/vrt-compare | Minor |
@spectrum-web-components/theme | Minor |
@spectrum-web-components/truncated | Minor |
documentation | Patch |
@spectrum-web-components/action-group | Minor |
@spectrum-web-components/action-menu | Minor |
@spectrum-web-components/combobox | Minor |
@spectrum-web-components/contextual-help | Minor |
@spectrum-web-components/menu | Minor |
@spectrum-web-components/overlay | Minor |
@spectrum-web-components/tabs | Minor |
@spectrum-web-components/number-field | Minor |
@spectrum-web-components/story-decorator | Minor |
@spectrum-web-components/slider | Minor |
@spectrum-web-components/breadcrumbs | Minor |
@spectrum-web-components/popover | Minor |
@spectrum-web-components/tooltip | Minor |
@spectrum-web-components/top-nav | Minor |
@spectrum-web-components/eslint-plugin | Minor |
@spectrum-web-components/accordion | Minor |
@spectrum-web-components/asset | Minor |
@spectrum-web-components/avatar | Minor |
@spectrum-web-components/badge | Minor |
@spectrum-web-components/checkbox | Minor |
@spectrum-web-components/close-button | Minor |
@spectrum-web-components/color-area | Minor |
@spectrum-web-components/color-field | Minor |
@spectrum-web-components/color-handle | Minor |
@spectrum-web-components/color-loupe | Minor |
@spectrum-web-components/color-slider | Minor |
@spectrum-web-components/color-wheel | Minor |
@spectrum-web-components/divider | Minor |
@spectrum-web-components/dropzone | Minor |
@spectrum-web-components/field-group | Minor |
@spectrum-web-components/field-label | Minor |
@spectrum-web-components/help-text | Minor |
@spectrum-web-components/icon | Minor |
@spectrum-web-components/icons-ui | Minor |
@spectrum-web-components/icons-workflow | Minor |
@spectrum-web-components/icons | Minor |
@spectrum-web-components/iconset | Minor |
@spectrum-web-components/link | Minor |
@spectrum-web-components/meter | Minor |
@spectrum-web-components/modal | Minor |
@spectrum-web-components/progress-bar | Minor |
@spectrum-web-components/progress-circle | Minor |
@spectrum-web-components/radio | Minor |
@spectrum-web-components/sidenav | Minor |
@spectrum-web-components/split-view | Minor |
@spectrum-web-components/status-light | Minor |
@spectrum-web-components/swatch | Minor |
@spectrum-web-components/switch | Minor |
@spectrum-web-components/table | Minor |
@spectrum-web-components/textfield | Minor |
@spectrum-web-components/thumbnail | Minor |
@spectrum-web-components/tray | Minor |
@spectrum-web-components/underlay | Minor |
@spectrum-web-components/base | Minor |
@spectrum-web-components/grid | Minor |
@spectrum-web-components/opacity-checkerboard | Minor |
@spectrum-web-components/reactive-controllers | Minor |
@spectrum-web-components/shared | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
wait what?
|
Yes, As of now if a single changeset file contains multiple entries or frontmatter blocks—each describing a distinct change—only the first one will be considered during changelog generation. I'm not sure if this behavior is intentional or if we should instead support concatenating multiple entries. As per recommended approach by the community, one entry per file is encouraged which also encourages devs to create separate changeset files for unrelated changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Removed button from changeset front matter on the changes for the clear button fixWe adjusted this to prioritize the changes for the
clear-button
package for the global changelog and reworked the description to clarify the related changes in thebutton
andstyles
packages.Motivation and context
Our current changeset generation script only takes the first front matter info into the changelog. The update is done till we update the script to formalize the changelog for multiple component changes.
[IMPORTANT]: Needed for the upcoming release.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review