feat(button,clear-button): updated styles and deprecated overBackground variant [SWC-860] - abandoned #5320
+281
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
🦋 Changeset detectedLatest commit: 8067e22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChromebutton permalinktest-basic
Firefoxbutton permalinktest-basic
|
renovate
bot
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
from
5bfb3f3 to
7ae6c7e
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
from
7ae6c7e to
b162585
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
2 times, most recently
from
94e30d0 to
81a0736
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
2 times, most recently
from
6f55396 to
eb41ccc
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
3 times, most recently
from
d20ef41 to
4eea58d
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
2 times, most recently
from
4b90709 to
c4432c9
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
2 times, most recently
from
28c36a3 to
2a416d6
Compare
|
Work represented in SWC-860 |
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
from
2a416d6 to
2f04894
Compare
caseyisonit
reviewed
May 6, 2025
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
2 times, most recently
from
8b98d85 to
5a9adf8
Compare
castastrophe
approved these changes
May 7, 2025
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
4 times, most recently
from
d981956 to
d316716
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
8 times, most recently
from
fa996c5 to
8ade2a3
Compare
|
I am not sure if this should be |
It adds 2 new attributes: [quiet] and [static-color="white"] You can find more details in my changeset description. |
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
from
8ade2a3 to
5b43912
Compare
| */ | ||
| @property({ reflect: true }) | ||
| public variant: 'overBackground' | '' = ''; | ||
| public set variant(variant: 'overBackground' | undefined) { |
There was a problem hiding this comment.
@rubencarvalho @nikkimk If you have a chance, do you know if there's a more efficient or "lit-ified" way to handle this backwards compatibility?
castastrophe
added
ready-for-review
enhancement
caseyisonit
changed the title
renovate
bot
changed the title
castastrophe
force-pushed
the
renovate/spectrum-css-clearbutton-7.x
branch
from
5b43912 to
8067e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
7.0.0-s2-foundations.16->7.2.0Release Notes
adobe/spectrum-css (@spectrum-css/clearbutton)
v7.2.0Compare Source
Minor Changes
5f1751cThanks @castastrophe! - By updating the postcss-preset-env to the latest breaking change version, output for this component no longer injects the.js-focus-withinand '[focus-within]` selectors for the focus-within polyfill. As this feature is not used in the SWC consumption, risk to the end user for this removal is low.v7.1.0Compare Source
Minor Changes
📝
205182bThanks @castastrophe!v7.0.1Compare Source
Patch Changes
📝 #3534
68e0057Thanks @castastrophe!Fixes a bug in the content of the
dist/index-theme.cssfile.Expected
index-theme.cssto include the component selectors with component-level custom properties mapped to the--systemprefixed ones in order to allow a component to support various contexts.Expected output example for the index-theme.css:
68e0057]:v7.0.0Compare Source
Major Changes
📝 #2786
6c19fcfThanks @pfulton!🛑 Breaking change
This major update creates a bridge between the Spectrum 1 (S1) and Spectrum 2 (S2) designs, dubbed "Spectrum 2 Foundations". These do NOT reflect a fully migrated S2 component. This approach allows consumers to swap the appearance of their components between S1, Express, and S2 by leveraging a "system" layer that remaps the necessary component-level tokens to the appropriate token dataset.
For these components to appear S2, you must load the assets with the
@spectrum-css/tokensatv16or higher.For S1 or Express, load assets with the
@spectrum-css/tokensatv14.xorv15.x.If you are looking to implement a fully S2 design, please explore the
nexttag releases instead of using this foundations release. This release is used in Spectrum Web Components 1.x.Deprecations
The
metadatafolder containing themods.mdandmetadata.jsonassets has been removed from source. To find information about the components including what selectors, modifiers, and passthroughs are used, please see thedist/metadata.jsonasset shipped with every component containing CSS.The
index-vars.cssasset has been removed in this release as it was previously deprecated and is no longer maintained. Please use theindex.cssorindex-base.cssFile usage
If you are rendering components and need only the S2 Foundations styles, you can make use of the
index.cssasset which contains all the base styles plus the system mappings for S2 Foundations.If you are using this version to publish only an S1 or Express component, you can use the
index-base.cssplus the desiredthemes/(spectrum|express).cssfile.To render a component that can be easily swapped between the S2 Foundations, S1, or Express contexts, load
index-base.csswith theindex-theme.cssfile and leverage the appropriate context classes (.spectrum--legacyfor S1 and.spectrum--expressfor Express).Patch Changes
6c19fcf,3d08cea,6c19fcf]:v7.0.0-s2-foundations.17Compare Source
Major Changes
#2786
f6ad55eThanks @pfulton! - feat: s2 foundations non-gray-800 colors update--spectrum-blue-800--spectrum-red-800--spectrum-orange-800--spectrum-yellow-800--spectrum-chartreuse-800--spectrum-celery-800--spectrum-green-800--spectrum-seafoam-800--spectrum-cyan-800--spectrum-indigo-800--spectrum-purple-800--spectrum-fuchsia-800--spectrum-magenta-800--spectrum-pink-800--spectrum-turqoise-800--spectrum-brown-800--spectrum-silver-800--spectrum-cinnamon-800Patch Changes
f6ad55e]:Configuration
📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.