Skip to content

chore: update dependency @spectrum-css/dialog to v12.1.0 #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+963 −2,972
Open

chore: update dependency @spectrum-css/dialog to v12.1.0 #5304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c98fe0
chore: update dependency @spectrum-css/dialog to v11.0.1
renovate[bot] Mar 31, 2025
0d1a20c
fix(dialog,styles): use latest CSS
castastrophe Mar 31, 2025
fc960b3
chore: prettier settings for all CSS
castastrophe May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dialog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"@spectrum-web-components/underlay": "1.6.0"
},
"devDependencies": {
"@spectrum-css/dialog": "11.0.0-s2-foundations.15"
"@spectrum-css/dialog": "12.1.0"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
22 changes: 0 additions & 22 deletions packages/dialog/src/dialog-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,3 @@ governing permissions and limitations under the License.
*/

/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
:host {
--spectrum-dialog-fullscreen-header-text-size: var(--system-dialog-fullscreen-header-text-size);
--spectrum-dialog-min-inline-size: var(--system-dialog-min-inline-size);
--spectrum-dialog-confirm-small-width: var(--system-dialog-confirm-small-width);
--spectrum-dialog-confirm-medium-width: var(--system-dialog-confirm-medium-width);
--spectrum-dialog-confirm-large-width: var(--system-dialog-confirm-large-width);
--spectrum-dialog-confirm-divider-block-spacing-start: var(--system-dialog-confirm-divider-block-spacing-start);
--spectrum-dialog-confirm-divider-block-spacing-end: var(--system-dialog-confirm-divider-block-spacing-end);
--spectrum-dialog-confirm-description-text-color: var(--system-dialog-confirm-description-text-color);
--spectrum-dialog-confirm-title-text-color: var(--system-dialog-confirm-title-text-color);
--spectrum-dialog-confirm-description-text-line-height: var(--system-dialog-confirm-description-text-line-height);
--spectrum-dialog-confirm-title-text-line-height: var(--system-dialog-confirm-title-text-line-height);
--spectrum-dialog-heading-font-weight: var(--system-dialog-heading-font-weight);
--spectrum-dialog-confirm-description-padding: var(--system-dialog-confirm-description-padding);
--spectrum-dialog-confirm-description-margin: var(--system-dialog-confirm-description-margin);
--spectrum-dialog-confirm-footer-padding-top: var(--system-dialog-confirm-footer-padding-top);
--spectrum-dialog-confirm-gap-size: var(--system-dialog-confirm-gap-size);
--spectrum-dialog-confirm-buttongroup-padding-top: var(--system-dialog-confirm-buttongroup-padding-top);
--spectrum-dialog-confirm-close-button-size: var(--system-dialog-confirm-close-button-size);
--spectrum-dialog-confirm-close-button-padding: var(--system-dialog-confirm-close-button-padding);
--spectrum-dialog-confirm-divider-height: var(--system-dialog-confirm-divider-height);
}
44 changes: 18 additions & 26 deletions packages/dialog/src/dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
governing permissions and limitations under the License.
*/

@import url('./spectrum-dialog.css');
@import url('./dialog-overrides.css');
@import url("./spectrum-dialog.css");

:host {
--swc-alert-dialog-error-icon-color: var(--spectrum-negative-visual-color);
Expand All @@ -22,53 +21,46 @@ governing permissions and limitations under the License.
}

.footer {
color: var(
--spectrum-dialog-confirm-description-text-color,
var(--spectrum-gray-800)
);
color: var(--spectrum-dialog-confirm-description-text-color, var(--spectrum-gray-800));
}

.type-icon {
grid-area: typeIcon;
color: var(
--mod-alert-dialog-error-icon-color,
var(--swc-alert-dialog-error-icon-color)
);
color: var(--mod-alert-dialog-error-icon-color, var(--swc-alert-dialog-error-icon-color));
}

.content[tabindex] {
overflow: auto;
}

::slotted(img[slot='hero']) {
::slotted(img[slot="hero"]) {
width: 100%;
height: auto;
}

/* We may remove this override when CSS fixes unused `header` and `typeIcon` areas */
.grid {
grid-template-areas:
'hero hero hero hero hero hero'
'. . . . . .'
'. heading heading heading typeIcon . '
'. divider divider divider divider .'
'. content content content content .'
'. footer footer buttonGroup buttonGroup .'
'. . . . . .';
"hero hero hero hero hero hero"
". . . . . ."
". heading heading heading typeIcon . "
". divider divider divider divider ."
". content content content content ."
". footer footer buttonGroup buttonGroup ."
". . . . . .";
inline-size: 100%;
display: grid;
}

/* Needed while `error` attribute still exists as deprecated */
:host(:not([error], [dismissable], [mode])) .grid {
grid-template-areas:
'hero hero hero hero hero hero'
'. . . . . .'
'. heading heading heading heading . '
'. divider divider divider divider .'
'. content content content content .'
'. footer footer buttonGroup buttonGroup .'
'. . . . . .';
"hero hero hero hero hero hero"
". . . . . ."
". heading heading heading heading . "
". divider divider divider divider ."
". content content content content ."
". footer footer buttonGroup buttonGroup ."
". . . . . .";
inline-size: 100%;
display: grid;
}
43 changes: 25 additions & 18 deletions packages/dialog/src/spectrum-dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,31 @@ governing permissions and limitations under the License.

/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
:host {
--spectrum-dialog-confirm-divider-block-spacing-start: var(--spectrum-spacing-300);
--spectrum-dialog-confirm-divider-block-spacing-end: var(--spectrum-spacing-200);
--spectrum-dialog-confirm-description-text-color: var(--spectrum-gray-800);
--spectrum-dialog-confirm-description-padding: var(--spectrum-spacing-50);
--spectrum-dialog-confirm-gap-size: var(--spectrum-component-pill-edge-to-text-100);
--spectrum-dialog-confirm-buttongroup-padding-top: var(--spectrum-spacing-600);
--spectrum-dialog-confirm-close-button-size: var(--spectrum-component-height-100);
--spectrum-dialog-confirm-close-button-padding: calc(26px - var(--spectrum-component-bottom-to-text-300));
box-sizing: border-box;
inline-size: fit-content;
min-inline-size: var(--mod-dialog-min-inline-size, var(--spectrum-dialog-min-inline-size));
inline-size: 480px;
inline-size: var(--mod-dialog-width, var(--mod-dialog-confirm-medium-width, 480px));
min-inline-size: 288px;
min-inline-size: var(--mod-dialog-min-inline-size, 288px);
max-inline-size: 100%;
max-block-size: inherit;
outline: none;
display: flex;
}

:host([size="s"]) {
inline-size: var(--mod-dialog-confirm-small-width, var(--spectrum-dialog-confirm-small-width));
.spectrum-Dialog--sizeS {
--mod-dialog-width: var(--mod-dialog-confirm-small-width, 400px);
}

:host([size="m"]) {
inline-size: var(--mod-dialog-confirm-medium-width, var(--spectrum-dialog-confirm-medium-width));
}

:host([size="l"]) {
inline-size: var(--mod-dialog-confirm-large-width, var(--spectrum-dialog-confirm-large-width));
.spectrum-Dialog--sizeL {
--mod-dialog-width: var(--mod-dialog-confirm-large-width, 640px);
}

::slotted([slot="hero"]) {
Expand Down Expand Up @@ -60,9 +66,9 @@ governing permissions and limitations under the License.

::slotted([slot="heading"]) {
font-size: var(--mod-dialog-confirm-title-text-size, var(--spectrum-dialog-confirm-title-text-size));
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-dialog-heading-font-weight));
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-dialog-confirm-title-text-line-height));
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-dialog-confirm-title-text-color));
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-heading-sans-serif-font-weight));
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-line-height-100));
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-gray-900));
outline: none;
grid-area: heading;
margin: 0;
Expand Down Expand Up @@ -99,18 +105,18 @@ governing permissions and limitations under the License.
}

:host([no-divider]) ::slotted([slot="heading"]) {
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-dialog-confirm-divider-height)));
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-spacing-50)));
}

.content {
box-sizing: border-box;
-webkit-overflow-scrolling: touch;
font-size: var(--mod-dialog-confirm-description-text-size, var(--spectrum-dialog-confirm-description-text-size));
font-weight: var(--mod-dialog-confirm-description-font-weight, var(--spectrum-regular-font-weight));
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-dialog-confirm-description-text-line-height));
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-line-height-100));
color: var(--mod-dialog-confirm-description-text-color, var(--spectrum-dialog-confirm-description-text-color));
padding: calc(var(--mod-dialog-confirm-description-padding, var(--spectrum-dialog-confirm-description-padding)) * 2);
margin: 0 var(--mod-dialog-confirm-description-margin, var(--spectrum-dialog-confirm-description-margin));
margin: 0 var(--mod-dialog-confirm-description-margin, calc(var(--spectrum-spacing-50) * -1));
outline: none;
grid-area: content;
overflow-y: auto;
Expand All @@ -120,7 +126,7 @@ governing permissions and limitations under the License.
outline: none;
flex-wrap: wrap;
grid-area: footer;
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-dialog-confirm-footer-padding-top));
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-spacing-600));
display: flex;
}

Expand Down Expand Up @@ -202,7 +208,8 @@ governing permissions and limitations under the License.

:host([mode="fullscreen"]) ::slotted([slot="heading"]),
:host([mode="fullscreenTakeover"]) ::slotted([slot="heading"]) {
font-size: var(--mod-dialog-fullscreen-header-text-size, var(--spectrum-dialog-fullscreen-header-text-size));
font-size: 28px;
font-size: var(--mod-dialog-fullscreen-header-text-size, 28px);
}

:host([mode="fullscreen"]) .content,
Expand Down
Loading
Loading