WIP chore: remove coachmark indicator "variant" #4759
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubencarvalho
force-pushed
the
ruben/remove-coach-indicator
branch
from
68587ca
to
716eb2a
Compare
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
rubencarvalho
changed the title
Tachometer resultsChromecoachmark permalinkbasic-test
Firefoxcoachmark permalinkbasic-test
|
rubencarvalho
changed the title
rubencarvalho
changed the title
rubencarvalho
force-pushed
the
ruben/remove-coach-indicator
branch
from
716eb2a
to
55dbbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the
sp-coach-indicator"variant" attribute, along with all associated references and dependencies.Related issue(s)
Motivation and context
For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.