-
Notifications
You must be signed in to change notification settings - Fork 202
feat(slider): S2 migration, new precision variant, embedded textfield #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aramos-adobe
wants to merge
26
commits into
spectrum-two
Choose a base branch
from
aramos-adobe/css1201-s2-slider-handle-variant
base: spectrum-two
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,033
−312
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
5e3894c
feat(slider): wip track height and gap
aramos-adobe 9975e73
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe 4384a5f
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe af0af60
feat(slider): adding precision variant
aramos-adobe 750cf36
feat(slider): added emphasized mode, updated ticks
aramos-adobe 5f0b436
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe dacccde
feat(slider): adding changeset description
aramos-adobe 1f0f24f
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe 31cf9f1
feat(slider): adjust WHCM and typography
aramos-adobe b96ddfa
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe f061fd4
feat(slider): adding more test cases for emphasized range
aramos-adobe b998c67
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe 48ae945
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe b3d3403
feat(slider): updating pr
aramos-adobe 3bf6d0b
Merge branch 'aramos-adobe/css1201-s2-slider-handle-variant' of https…
aramos-adobe d2f9540
feat(slider): cleaning custom tokens, textfield focus state
aramos-adobe 4d8db3b
feat(slider): update whcm, using dist tokens
aramos-adobe 8178919
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe 7d9ea7f
feat(slider): new reviews update focus states and tokens
aramos-adobe f80415b
feat(slider): update metadata
aramos-adobe e30230a
feat(slider): restoring base project files
aramos-adobe 5c7b2b5
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe dde14d1
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe b7a3393
feat(slider): use field label passthrough for top padding
aramos-adobe 7694835
Merge branch 'spectrum-two' into aramos-adobe/css1201-s2-slider-handl…
aramos-adobe cde957b
feat(slider): adding new changes and updates to story and css
aramos-adobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
--- | ||
@spectrum-css/slider: major | ||
--- | ||
|
||
### S2 Slider Migration | ||
|
||
#### New features | ||
|
||
- Emphasized track fill color | ||
- Precision control handle | ||
- Large and thin track heights | ||
- Embedded editable text field component | ||
|
||
#### Visual changes | ||
|
||
- No longer a gap between slider handle and the track | ||
- Updated dimensions of slider handles for each size variant | ||
- Updated WHCM for all variants | ||
|
||
|
||
#### New tokens | ||
|
||
`--spectrum-slider-control-to-field-label-editable-extra-large` | ||
`--spectrum-slider-control-to-field-label-editable-large` | ||
`--spectrum-slider-control-to-field-label-editable-medium` | ||
`--spectrum-slider-control-to-field-label-editable-small` | ||
`--spectrum-slider-control-to-side-field-label-extra-large` | ||
`--spectrum-slider-control-to-side-field-label-large` | ||
`--spectrum-slider-control-to-side-field-label-medium` | ||
`--spectrum-slider-control-to-side-field-label-small` | ||
`--spectrum-slider-control-to-text-field-extra-large` | ||
`--spectrum-slider-control-to-text-field-large` | ||
`--spectrum-slider-control-to-text-field-medium` | ||
`--spectrum-slider-control-to-text-field-small` | ||
`--spectrum-slider-editable-control-to-field-label` | ||
`--spectrum-slider-editable-control-to-text-field` | ||
`--spectrum-slider-editable-field-inline-size-extra-large` | ||
`--spectrum-slider-editable-field-inline-size-large` | ||
`--spectrum-slider-editable-field-inline-size-medium` | ||
`--spectrum-slider-editable-field-inline-size-small` | ||
`--spectrum-slider-emphasized-track-fill-color` | ||
`--spectrum-slider-precision-handle-height` | ||
`--spectrum-slider-precision-handle-height-extra-large` | ||
`--spectrum-slider-precision-handle-height-large` | ||
`--spectrum-slider-precision-handle-height-medium` | ||
`--spectrum-slider-precision-handle-height-small` | ||
`--spectrum-slider-precision-handle-width` | ||
`--spectrum-slider-handle-extra-large` | ||
`--spectrum-slider-handle-large` | ||
`--spectrum-slider-handle-medium` | ||
`--spectrum-slider-handle-small` | ||
|
||
#### New mods | ||
|
||
`--mod-slider-editable-control-to-text-field` | ||
`--mod-slider-editable-field-inline-size` | ||
`--mod-slider-disabled-border-color` | ||
`--mod-slider-emphasized-tick-mark-color` | ||
`--mod-slider-emphasized-track-fill-color` | ||
`--mod-slider-inline-size` | ||
`--mod-slider-label-font-style` | ||
`--mod-slider-label-font-weight` | ||
`--mod-slider-ramp-track-fill-color` | ||
`--mod-slider-tick-mark-color-filled-track` | ||
`--mod-slider-track-height-medium` | ||
|
||
#### Removed mods | ||
|
||
`--mod-disabled-border-color` | ||
`--mod-sectrum-slider-ramp-handle-border-color-active` | ||
`--mod-slider-handle-border-width-down` | ||
`--mod-slider-handle-gap` | ||
`--mod-slider-ramp-handle-background-color` | ||
`--mod-slider-tick-handle-background-color` | ||
`--mod-slider-tick-mark-color-disabled` | ||
`--mod-slider-track-handleoffset` | ||
`--mod-slider-track-margin-offset` | ||
`--mod-slider-track-middle-handleoffset` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.