fix: update accessibility data processing and opportunity creation #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
dmaurya929
force-pushed
the
form-accessibility-version
branch
from
440f663 to
61adc15
Compare
nit23uec
reviewed
Jun 2, 2025
src/forms-opportunities/oppty-handlers/accessibility-handler.js
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Jun 2, 2025
| * @returns {Promise<void>} | ||
| */ | ||
| // eslint-disable-next-line max-len | ||
| export default async function handler(message, context) { | ||
| export async function createOpportunity(auditId, siteId, a11yData, context) { |
There was a problem hiding this comment.
is this function used anywhere outside this module too?
vdua
reviewed
Jun 2, 2025
src/forms-opportunities/oppty-handlers/accessibility-handler.js
Outdated
Show resolved
Hide resolved
vdua
reviewed
Jun 2, 2025
src/forms-opportunities/oppty-handlers/accessibility-handler.js
Outdated
Show resolved
Hide resolved
- Modified `getObjectKeysFromSubfolders` to include a `storagePrefix` parameter for better flexibility in S3 path management. - Refactored `createAccessibilityOpportunity` to streamline the process of creating accessibility opportunities, including improved error handling and logging. - Updated tests to reflect changes in the accessibility opportunity creation logic and ensure proper functionality. - Removed deprecated references to `formA11yData` in the scraping utility to simplify data handling.
dmaurya929
force-pushed
the
form-accessibility-version
branch
from
61adc15 to
21853e9
Compare
nit23uec
approved these changes
Jun 3, 2025
solaris007
pushed a commit
that referenced
this pull request
Jun 3, 2025
## [1.97.6](v1.97.5...v1.97.6) (2025-06-03) ### Bug Fixes * **forms-a11y:** update accessibility data processing and opportunity creation ([#924](#924)) ([6199178](6199178))
|
🎉 This PR is included in version 1.97.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getObjectKeysFromSubfoldersto include astoragePrefixparameter for better flexibility in S3 path management.createAccessibilityOpportunity