wip: fixes controller #850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidaurelio
force-pushed
the
aurelio/fixes-controller
branch
from
72c340e to
3104b7b
Compare
|
This PR will trigger no release when merged. |
alinarublea
reviewed
May 15, 2025
| type: string | ||
| format: uuid | ||
| suggestionId: |
There was a problem hiding this comment.
Here it s actually the opportunityId
alinarublea
reviewed
May 15, 2025
| constructor(dataAccess) { | ||
| this.#FixEntity = dataAccess.FixEntity; | ||
|
|
||
| this.getAllForOpportunity = this.getAllForOpportunity.bind(this); |
There was a problem hiding this comment.
Why do we need to bind the methods for the controller ?
There was a problem hiding this comment.
because they are simply referenced at https://github.com/adobe/spacecat-api-service/pull/850/files#diff-268a45f8e3c5fba5953593271f7aaed3d91812853a17dea472417fcc17c84bfdR169-R176
Alternatively, I can use arrow functions there.
lmk what you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
Thanks for contributing!