fix: prevent unhandled 5xx in scrape controller on malformed URLs#2292
Open
radhikagpt1208 wants to merge 4 commits intomainfrom
Open
fix: prevent unhandled 5xx in scrape controller on malformed URLs#2292radhikagpt1208 wants to merge 4 commits intomainfrom
radhikagpt1208 wants to merge 4 commits intomainfrom
Conversation
…ITES-43697 Two defensive fixes surfaced by the APIGatewayErrorRateHigh alert (SKYSI-76262) where a caller sent base64-encoded multi-line text in place of a URL: - getScrapeUrlByProcessingType now validates the decoded URL via isValidUrl() and returns 400 for non-URL input, mirroring getScrapeJobsByBaseURL. - createErrorResponse strips CR/LF and truncates error.message before placing it in the x-error header. Without this, multi-line messages threw ERR_INVALID_CHAR from @adobe/fetch's Headers.set, escaped the catch block, and surfaced as unhandled Lambda 500s — the actual driver of the alert burst. Adds 4 unit tests covering both behaviors.
|
This PR will trigger a patch release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
radhikagpt1208
temporarily deployed
to
dev-branches
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.corp.adobe.com/browse/SITES-43697
Two defensive fixes surfaced by the APIGatewayErrorRateHigh alert (SKYSI-76262) where a caller sent base64-encoded multi-line text in place of a URL:
getScrapeUrlByProcessingType now validates the decoded URL via isValidUrl() and returns 400 for non-URL input, mirroring getScrapeJobsByBaseURL.
createErrorResponse strips CR/LF and truncates error.message before placing it in the x-error header. Without this, multi-line messages threw ERR_INVALID_CHAR from @adobe/fetch's Headers.set, escaped the catch block, and surfaced as unhandled Lambda 500s — the actual driver of the alert burst.
Adds 4 unit tests covering both behaviors.
Thanks for contributing!