Skip to content

fix(aem-eds): clean up tile to clear all lint warnings#104

Open
shsteimer wants to merge 4 commits intomainfrom
fix/eds-register-missing-skills
Open

fix(aem-eds): clean up tile to clear all lint warnings#104
shsteimer wants to merge 4 commits intomainfrom
fix/eds-register-missing-skills

Conversation

@shsteimer
Copy link
Copy Markdown
Collaborator

@shsteimer shsteimer commented Apr 28, 2026

Summary

Five fixes that take the EDS plugin tile to a clean lint state (only the unrelated `code-review` token-bloat warning remains, deferred to a follow-up):

  1. Register `da-auth` and `ue-component-model` in `tile.json`. Both existed on disk but were missing from the skills map, so tessl never saw them.
  2. Add release-stub `package.json` for `ue-component-model`. Every other EDS skill has one (semantic-release-monorepo requirement); this skill was missing it.
  3. Add `.tileignore` to suppress release-artifact lint noise. `CHANGELOG.md` and skill-root `package.json` files are not skill content. Negation pattern (`!/scripts//package.json`) preserves any future skills shipping node script tools under `scripts/`.
  4. Rename `resources/` → `references/` across 8 skills to match the agentskills.io spec. Every other plugin in this repo and EDS's own `ue-component-model` already use `references/`.
  5. Convert backtick-quoted resource paths to markdown links in SKILL.md so tessl lint sees them as reachable from manifest entrypoints. Eliminates all 17 orphan warnings. Also fixes two pre-existing broken cross-skill references that pointed at `../page-import/resources/...` (no such dir; actual file lives in `content-driven-development/references/`). Adds a missing link in `code-review/SKILL.md` to `references/review-checklist.md`.

Per Anthropic's agent skills spec, markdown links don't trigger eager loading — Claude reads SKILL.md, sees the link, decides on demand whether to follow it. Confirmed in lint output: on-demand token range now shows lazy bounds (e.g., building-blocks `2.3k-6.7k`) rather than a single value, with the lower bound unchanged from before.

Verification

Before:
```
⚠ Found 36 orphaned file(s) not linked from manifest entrypoints
⚠ Found 20 skill file(s) outside spec directories
⚠ Skill 'code-review': SKILL.md is approximately 10277 tokens
```

After:
```
⚠ Skill 'code-review': SKILL.md is approximately 10315 tokens
✔ Tile adobe/aem-edge-delivery-services@0.1.0 is valid
```

`tessl skill publish plugins/aem/edge-delivery-services --dry-run` confirms a valid tile with all 20 skills declared.

Follow-ups (separate PRs)

  • `tessl skill lint` in CI — fail on errors, surface warnings as informational.
  • The release workflow's auto-publish path (`release.config.cjs:28`) only fires when a per-skill `tile.json` exists in the released directory. Plugin-level multi-skill tiles like this one never auto-publish on merge.
  • `code-review` SKILL.md is ~10.3k tokens (recommended max 5k). Trim by hoisting detail into `references/` files.

🤖 Generated with Claude Code

Two skills existed in the skills/ directory but were absent from
tile.json, so tessl never saw them. Adds both to the skills map and
creates the missing package.json for ue-component-model so the release
workflow can pick it up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Suppresses tessl lint warnings about CHANGELOG.md and package.json
files that exist as semantic-release / semantic-release-monorepo
artifacts but are not skill content.

Negation pattern preserves package.json files under scripts/ so that
future skills shipping node script tools have their packaging metadata
bundled correctly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shsteimer shsteimer changed the title fix(aem-eds): register da-auth and ue-component-model in tile fix(aem-eds): clean up tile registration and lint warnings Apr 28, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Renames resources/ to references/ across 8 skills to match the
agentskills.io spec — every other plugin in this repo and EDS's own
ue-component-model already use references/.

Converts backtick-quoted resource paths in SKILL.md to markdown links
so tessl lint sees them as reachable from manifest entrypoints,
eliminating all 17 orphan warnings. Also fixes two pre-existing broken
cross-skill references that pointed at ../page-import/resources/...
(no such directory); the actual file lives in
content-driven-development/references/.

Adds a markdown link in code-review/SKILL.md to its previously
unreferenced references/review-checklist.md.

Per Anthropic's agent skills spec, markdown links don't trigger eager
loading — Claude reads SKILL.md, sees the link, decides on demand
whether to follow it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shsteimer shsteimer changed the title fix(aem-eds): clean up tile registration and lint warnings fix(aem-eds): clean up tile to clear all lint warnings Apr 28, 2026
shsteimer added a commit that referenced this pull request Apr 28, 2026
Adds a trailing comment marker to page-import SKILL.md so the
tessl-lint workflow (introduced in #106) sees a tile change and runs
against the EDS tile in its current main-branch state (with all the
warnings PR #104 will fix). Demonstrates how warnings surface in the
GitHub UI.

This PR will be closed without merging.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant