Skip to content

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Oct 23, 2025

Firefox Release 144.0 added support for the View Transitions API, however it does not support the callbackOptions parameter, so it would throw an error and not show the toast at all.

This PR updates the startViewTransition call to just pass the updateCallback in.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test S2 Toast in all major browser and confirm that toast is shown and removed with view transition.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 23, 2025

@reidbarber
Copy link
Member Author

I'm seeing one issue where in the S2 docs where in Firefox, the "React Spectrum" logo + text in the header is temporarily hidden during the view transition. Those elements have their own view transitions. Not seeing this in any other browsers.

@devongovett
Copy link
Member

Those elements have their own view transitions.

I think we would need to only apply the view-transition-name just before the transition and remove it just after. Otherwise it will transition whenever any view transition on the page happens, not just when the search menu opens or closes.

@reidbarber
Copy link
Member Author

@devongovett sounds good, we can handle that in a separate PR later

@reidbarber reidbarber added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 8fb1b61 Oct 24, 2025
34 checks passed
@reidbarber reidbarber deleted the toast-view-transition-fix branch October 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants