docs: more S2 docs fixes #8944
Open
docs: more S2 docs fixes #8944
+491
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
weird, the S2 docs didn't build? |
|
Build successful! 🎉 |
devongovett
reviewed
Sep 30, 2025
| - Remove `validationState="valid"` (it is no longer supported in Spectrum 2) | ||
| - Update `Item` to be a `PickerItem` | ||
| - Change `isLoading` to `loadingState` and provide the appropriate loading state. | ||
| - Update `defaultSelectedKey` and `selectedKey` to be `defaultValue` and `value` respectively. See the [Picker](Picker.html#value) documentation for more details. |
There was a problem hiding this comment.
Want to update the storybook version of this migrating doc too?
There was a problem hiding this comment.
Should be handled by #8946
There was a problem hiding this comment.
ah it didn't change the placeholder stuff though looks like
devongovett
reviewed
Sep 30, 2025
| @@ -1,30 +0,0 @@ | |||
| import {Layout} from '../src/Layout'; | |||
There was a problem hiding this comment.
I think we should replace this page with some info about the status of the website (that it's in beta) and links to the various libraries for now. @dannify anything specific you want it to say?
devongovett
reviewed
Sep 30, 2025
| selectedKeys={selectedSection ? [selectedSection] : []} | ||
| onSelectionChange={handleTagSelection} | ||
| styles={style({margin: 12})} | ||
| UNSAFE_style={{overflow: 'auto', whiteSpace: 'nowrap', paddingBlock: 8}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: