Skip to content

fix: do not dispatch loadMore if hook is still in loading state #8571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2025

Conversation

jluyau
Copy link
Member

@jluyau jluyau commented Jul 17, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • in the S2 storybook, load the TableView > Test story
  • note when switching between the All and A New Hope film filters, there's only one load call (logged in console as well)
  • also note that when switching from All -> A New Hope, there's only 1 load called initially, and the second page call isnt made until scrolling down more (previous to this fix, the call would be made immediately)

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 18, 2025

@rspbot
Copy link

rspbot commented Jul 18, 2025

@reidbarber reidbarber added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 675dc30 Jul 18, 2025
31 checks passed
@reidbarber reidbarber deleted the async-list-fix branch July 18, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants