Skip to content

chore: Revert "feat: Prevent onChange from firing in TextFields while user is typing via IME (#8519)" #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

chore: Revert "feat: Prevent onChange from firing in TextFields while user is typing via IME (#8519)" #8554

merged 1 commit into from
Jul 16, 2025

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jul 15, 2025

This reverts commit 769d725.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu LFDanLu changed the title Revert "feat: Prevent onChange from firing in TextFields while user is typing via IME (#8519)" chore: Revert "feat: Prevent onChange from firing in TextFields while user is typing via IME (#8519)" Jul 15, 2025
@rspbot
Copy link

rspbot commented Jul 15, 2025

Build successful! 🎉

@LFDanLu LFDanLu added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 1a2cd52 Jul 16, 2025
31 of 32 checks passed
@LFDanLu LFDanLu deleted the revert_IME_change branch July 16, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LFDanLu @rspbot @devongovett @snowystinger