Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DatePicker with defaultValue persists time zone #7069

Merged
merged 11 commits into from
Nov 1, 2024
Merged

fix: DatePicker with defaultValue persists time zone #7069

merged 11 commits into from
Nov 1, 2024

Conversation

boutahlilsoufiane
Copy link
Contributor

@boutahlilsoufiane boutahlilsoufiane commented Sep 23, 2024 •
edited
Loading

Closes #6005

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@boutahlilsoufiane boutahlilsoufiane mentioned this pull request Sep 23, 2024
Closed
snowystinger
snowystinger previously approved these changes Sep 26, 2024
View reviewed changes
@snowystinger
Copy link
Member

Looks like you might need to sign the CLA? https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement

@boutahlilsoufiane
Copy link
Contributor Author

boutahlilsoufiane commented Sep 26, 2024 •
edited
Loading

@snowystinger thanks for the review, I have just signed the CLA.

@snowystinger
Copy link
Member

Thank, I'll close and reopen as it looks like it's stuck at the moment.

@snowystinger snowystinger reopened this Sep 26, 2024
@snowystinger
Copy link
Member

trying again to get it unstuck

@snowystinger snowystinger reopened this Sep 27, 2024
@snowystinger snowystinger reopened this Sep 27, 2024
@devongovett devongovett dismissed snowystinger’s stale review September 30, 2024 21:00

The merge-base changed after approval.

@snowystinger snowystinger changed the title DatePicker with defaultValue persists time zone fix: DatePicker with defaultValue persists time zone Oct 23, 2024
@yihuiliao yihuiliao added this pull request to the merge queue Nov 1, 2024
Merged via the queue into adobe:main with commit 14067de Nov 1, 2024
30 checks passed
@boutahlilsoufiane boutahlilsoufiane deleted the datepicker-persist-timezone branch November 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuiliao yihuiliao yihuiliao approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date pickers lose time zone when using the calendar after values are cleared
3 participants
@boutahlilsoufiane @snowystinger @yihuiliao