Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 add press events to Tab #6817

Open
wants to merge 229 commits into
base: main
Choose a base branch
from
Open

feat: 🎸 add press events to Tab #6817

wants to merge 229 commits into from

Conversation

ArrayKnight
Copy link

✅ Closes: #6810

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • yarn start
  • Navigate to Tabs Example in React Aria Components in Storybook
  • Notice that clicking on a Tab fires press event actions
  • Notice no breaking changes to existing tab behavior

snowystinger and others added 30 commits November 22, 2023 07:14
@snowystinger
Initial commit
1125c2b
@snowystinger
RAC storybook
31c8beb
@snowystinger
RAC Storybook
86ea039
@snowystinger
Got tailwind working!
d02a63b
@snowystinger
Start work on button
3db0978
@snowystinger
Get Spectrum styles working
12f3a9e
@snowystinger
remove unused files
97d640a
@snowystinger
Add perspective scaling for press
253ed1f
@snowystinger
Update README.md
78ced29
@snowystinger
remove docs, support theme swapping
7d0534e
@snowystinger
get back our controls
c14205b
@snowystinger
Add ActionButton, fix corner radius, add figma
a363251
@snowystinger
Add lint
cdcb680
@snowystinger
Add an icon, slot provider, static colors, sizes
6b948a4
@snowystinger
fix outline, add actiongroup for exploration
20b884b
@snowystinger
remove actiongroup, better press scale
178f0d4
@snowystinger
Add our wrapper elements for basic slots
d6bbb26
@snowystinger
Fix font
331fc60
@snowystinger
Merge pull request adobe#1 from React/fix-font
99feb19 
Fix font
@snowystinger
Update dependencies
a444091
@snowystinger
Merge pull request adobe#3 from React/update-deps
dd89da0 
Update dependencies
@snowystinger
Remove Tailwind
e8ea5bc
@snowystinger
Merge pull request adobe#5 from React/remove-tailwind
f848b20 
Remove Tailwind
@snowystinger
fix lint
d9a5b9c
@snowystinger
Merge pull request adobe#6 from React/fix-lint
8fb4a2e 
fix lint
@devongovett
setup macros
c45777d
@devongovett
fix patch
feff108
@devongovett
dark mode
ddfb669
@snowystinger
s2 wf icons (adobe#7)
d13fa7f
@devongovett
icons
7d5d2ef
Reid Barber and others added 28 commits July 9, 2024 09:46
@reidbarber
fix lint (adobe#199)
c7516c8 
* fix lint

* add skipLibCheck

* remove skipLibCheck

---------

Co-authored-by: Reid Barber <[email protected]>
@yihuiliao
Alert dialog (adobe#195)
f4c37b7 
* initialize alert dialog

* add alert dialog

* update story, fix closing

* remove comments

* remove props.styles

* update types

* remove orientation prop

* add aria-label to icons

* fix lint

---------

Co-authored-by: Yihui Liao <[email protected]>
@devongovett
Fix overlay trigger press scaling and menu description color (adobe#196)
25caaac
@devongovett
Publish
52c048e
@reidbarber
Fix rendering TagGroup inside GridList (adobe#6758)
291033b 
* fix rendering TagGroup inside GridList

* clear in GridListItem instead
@devongovett
Fix TagGroup docs example (adobe#6759)
05a37a0
@devongovett
Merge branch 'main' of github.com:adobe/react-spectrum
f0aa6aa
@snowystinger
Yarn 4 (adobe#6215)
976604a
Codemod follow-up (adobe#200)
52104c0
@devongovett
Merge branch 'main' into s2
12c81d4
@devongovett
Implement autofix for eslint sort imports rule (adobe#6766)
48af5db
@devongovett
Merge branch 'main' of github.com:adobe/react-spectrum into s2
0d77626
@snowystinger
Fix verdaccio build (adobe#6769)
32d4c0e
@devongovett
Spectrum 2
320061b
@devongovett
Merge branch 'main' of github.com:adobe/react-spectrum into spectrum-2
82adcfc
@ktabors
RSP nested tabs story (adobe#6756)
14f324f
@devongovett
Add Spectrum 2 docs to storybook
41be55b
@devongovett
Merge branch 'main' of github.com:adobe/react-spectrum into spectrum-2
c795330
@devongovett
Spectrum 2 (adobe#6777)
10a469d
@chirokas
Keep focus inside of ComboboxInput (adobe#6783)
1de2739 
* Keep focus inside of ComboboxInput
@devongovett
Yarn plugin to detect multiple versions of packages (adobe#6792)
efe2f80
@devongovett
Fix S2 ComboBox and NumberField custom width (adobe#6782)
826d9d4
@lithdew
fix(RAC): support hover events for Tabs (adobe#6742)
6dfa366 
support hover events for Tab
@snowystinger
Fix type regression on useControlledState signature (adobe#6789)
7aadd66
@snowystinger
Update Picker placeholder to be shorter (adobe#6796)
1dcc870
@ArrayKnight
feat: 🎸 add press events to Tab
ee4326d 
✅ Closes: adobe#6810
@reidbarber @snowystinger
test(docs): add script to test docs for warnings/errors (adobe#6763)
617ad2e 
* add script to test docs for warnings/errors

* get links before testing

* update yarn.lock

* update script to get latest browser binaries first

* support running with webkit and firefox

* exit process at the end

---------

Co-authored-by: Robert Snow <[email protected]>
@ArrayKnight
Merge branch 'main' into feat/tab-press
1febd5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PressEvents to Tab