chore: remove unused devDependencies - #10405
Open
reidbarber wants to merge 2 commits into
Open
Conversation
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
snowystinger
reviewed
Aug 1, 2026
| "devDependencies": { | ||
| "@react-aria/test-utils": "^1.0.0-alpha.8", | ||
| "@storybook/jest": "^0.2.3", | ||
| "@testing-library/dom": "^10.1.0", |
Member
There was a problem hiding this comment.
removed a little too much, yarn install has a new line item now
@react-spectrum/ai@workspace:packages/@react-spectrum/ai doesn't provide @testing-library/dom (p837d16), requested by @testing-library/user-event.
| "@parcel/optimizer-terser": "^2.16.3", | ||
| "@parcel/packager-react-static": "^2.16.3", | ||
| "@parcel/packager-ts": "^2.16.3", | ||
| "@parcel/reporter-bundle-analyzer": "^2.16.3", |
Member
There was a problem hiding this comment.
we should have a script target for running this one, it can be useful
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@testing-library/dom@npm:^10.4.1": |
Member
There was a problem hiding this comment.
this one should be deduped, the last time i tried to run yarn dedupe though things broke, so maybe just target this one, we can do the full dedupe later
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "prettier@npm:^3.6.2": |
Member
There was a problem hiding this comment.
how'd we end up with a newer prettier? i guess the devDep was pulling it down, we should probably just use the 3.8.1 version we already have or dedupe to the higher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused dev dependencies across the repo. No runtime code changes.
Root
package.json:is-mingw,walk-object@vitest/browser-preview@vitest/browser-playwright.@storybook/addon-themes.storybook*/mainaddons list.@parcel/reporter-bundle-analyzer.parcelrc, script, or CI workflow.eslint-plugin-jestoxlint(native jest plugin), no ESLint config exists.regenerator-runtimeWorkspace packages:
@parcel/transformer-s2-iconprettierdependenciesentry.@react-spectrum/ai@storybook/jest,@react-aria/test-utils,@testing-library/dom,@testing-library/react@react-spectrum/test-utils-internal+vitest-browser-react+@testing-library/user-event(kept).@react-spectrum/toast,@react-stately/toast@types/use-sync-external-storeuse-sync-external-storeis neither imported nor a dependency.@react-spectrum/contextualhelp@react-spectrum/link,@react-spectrum/viewreact-aria-components@tailwindcss/postcsstailwindcss-react-aria-components.✅ Pull Request Checklist:
📝 Test Instructions:
Smoke test
🧢 Your Project: