fix: MenuItem render function should not receive an href when not a link#10018
Open
devongovett wants to merge 1 commit intomainfrom
Open
fix: MenuItem render function should not receive an href when not a link#10018devongovett wants to merge 1 commit intomainfrom
devongovett wants to merge 1 commit intomainfrom
Conversation
snowystinger
approved these changes
May 6, 2026
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9988
Our docs say that you should check if
'href' in domPropsto conditionally render a link element, but this is currently always true (href is undefined). TypeScript is not smart enough to narrow the type when checking both conditions, so this PR removes the property entirely when it is not set on the input props.