chore: add testing sheet workflow to github#10003
Open
Conversation
|
Build successful! 🎉 |
Member
|
I think adding these tags is fine, will be helpful for release notes too I assume? Was this attached to the testing sheet automation work you were doing? |
Member
Author
|
@LFDanLu yeah this goes along with the testing sheet automation stuff. i imagine this will also be useful for release notes if we update the script |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:MenuSection MenuSection <T extends {}> {
aria-label?: string
children?: ReactNode | ({}) => ReactElement
className?: string = 'react-aria-MenuSection'
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
+ disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
id?: Key
items?: Iterable<{}>
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
style?: CSSProperties
value?: {}
}/react-aria-components:MenuSectionProps MenuSectionProps <T> {
aria-label?: string
children?: ReactNode | (T) => ReactElement
className?: string = 'react-aria-MenuSection'
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
+ disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
id?: Key
items?: Iterable<T>
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
style?: CSSProperties
value?: T
}@react-spectrum/s2/@react-spectrum/s2:MenuSection MenuSection <T extends {}> {
aria-label?: string
children?: ReactNode | (T) => ReactElement
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
+ disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
id?: Key
items?: Iterable<T>
onSelectionChange?: (Selection) => void
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
value?: T
}/@react-spectrum/s2:MenuSectionProps MenuSectionProps <T extends {}> {
aria-label?: string
children?: ReactNode | (T) => ReactElement
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
+ disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
id?: Key
items?: Iterable<T>
onSelectionChange?: (Selection) => void
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
value?: T
} |
LFDanLu
reviewed
May 6, 2026
Member
LFDanLu
left a comment
There was a problem hiding this comment.
Some preliminary questions from reading the PR description, haven't looked at the scripts just yet:
- So someone needs to create a sheet every week still? Which file does it mean by "download the file and upload it to the Testing folder"
- Am I understanding it correctly that the flow is roughly: "someone uploads a blank(?) new sheet to the testing folder" -> "Power Automate (some kind of automation by Microsoft?) will then run the scripts to get the commits for the past week and fill out the sheet" -> "the github workflow comments to slack the link to the sheet"?
- How much information (aka read/write) was github/sharepoint/slack able to expose to one another here? I'm assuming there were some limitations hence some of the more manual steps existing
- Is it possible for the "test off PR" tag to be stripped off automatically after it gets added to the test sheet? I'm just worried that people will forget to remove them after being tested and then a PR gets added to the next testing session afterwards
Member
|
will leave more comments here since github is having problem with PR line/files comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up a new github action that is triggered by a cron job (or manually) which looks at the commits made in the past 7 days and writes it to a excel spreadsheet (goodbye google sheets) and sends it as an attachment in a slack message.
One caveat is that someone will need to download the file and upload it to the Testing folder within the team's sharepoint. Once it's added to the folder, it will trigger a different job that will send a message to the RSP Weekly Testing Party with a link to the file. This job is set up within Power Automate so none of the file changes here are related to this part of the workflow.
Another thing is that this job will only look at the past 7 days. I know that sometimes testing gets bumped out or moved to another day. In that case, you can run it in the terminal like so
node scripts/sendWeeklyExcelSheet.mjs 2026-04-20 2026-05-02. Just make sure you have the correct Slack tokens. Everyone on the team should have access to the Testing Sheet App on Slack.I've also added more labels to the labeler workflow because we weren't great at adding labels manually (I'm also guilty of this).
In addition, I've added support of "test off PR" so if you have a PR that you want to test, just add the label and the spreadsheet should pick it up. There's also the "no testing" label which will skip over any PR's that don't need manual testing.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: