Rename feature ecs/ layer to services/main-service/ - #161
Merged
Conversation
Feature structure is now data/ · services/ · ui/. The former ecs/ layer becomes services/main-service/ — the ECS is an implementation detail behind the feature's sole entrypoint service — with capability services beside it under services/. Updates the data-ai AI rules/skills, restructures the Lit/GPU samples (imports fixed, all packages green), and adds data-lit-todo to the shipped references/. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the feature-folder
ecs/layer toservices/main-service/. The feature structure is now three layers —data/·services/·ui/— whereservices/holds themain-service/(the ECS-backed reactive state service, and the sole entrypoint the UI binds to) alongside any async capability-contract services. The ECS is now an implementation detail behind that service rather than a top-level layer.Changes
@adobe/data-ai): movedfeatures/ecs/**rules →features/services/main-service/**; rewrotefeatures/index.md(3-layer model, dependency +importspath); reframedfeatures/services/index.mdas a two-kind overview (main-service + capability contracts); demoted "ecs" from a layer label in thebuild-*skill descriptions.@adobe/data/ecslibrary imports left untouched throughout.data-lit-tictactoe,data-lit-todo,data-lit-space-rock-game,data-gpu-hopper(ecs/→services/main-service/; capability services now sit besidemain-service/; imports fixed viagit mv, history preserved).data-p2p-tictactoeunaffected (imports via the package barrel).data-lit-todoto the shippedreferences/(copy-references.js+AGENTS.md) and documentednode_modules/@adobe/data/references/<sample>/src/in the feature rule.Verification
Workspace typecheck green (all projects). Affected packages test green: tictactoe 34, todo 79, space-rock 148, gpu-hopper 84, p2p 7.
🤖 Generated with Claude Code