-
Notifications
You must be signed in to change notification settings - Fork 18
nx-shell user warning #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
auniverseaway
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out loud: I wonder if we also do this based on ref. I wouldn't advertise anything differently in your dialog, but we would maybe store in localStorage each branch decision.
We also probably need a follow up PR for being able to remove a permission. Small app? Something in the bottom corner of the shell?
Do make sure @sirugh is aware of these changes as we don't want him to be blindsided with support questions.
7351437
It'll still happen, but thanks :D |
Not sure if you saw the discussion on da-dev, but we added an allow list that won't show the warning on the commerce setup app. If you have any other apps to add to the list, let us know. |
If it's per "site", then |

Warn the user that they're giving their token to the app loaded by nx-shell.