Skip to content

Conversation

@hannessolo
Copy link
Contributor

Warn the user that they're giving their token to the app loaded by nx-shell.

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 25, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

auniverseaway
auniverseaway previously approved these changes Nov 25, 2025
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking out loud: I wonder if we also do this based on ref. I wouldn't advertise anything differently in your dialog, but we would maybe store in localStorage each branch decision.

We also probably need a follow up PR for being able to remove a permission. Small app? Something in the bottom corner of the shell?

Do make sure @sirugh is aware of these changes as we don't want him to be blindsided with support questions.

@hannessolo
Copy link
Contributor Author

I wonder if we also do this based on ref

That's exactly what it's doing :)

Screenshot 2025-11-25 at 19 05 09

@sirugh
Copy link
Contributor

sirugh commented Dec 1, 2025

we don't want him to be blindsided with support questions.

It'll still happen, but thanks :D

@hannessolo
Copy link
Contributor Author

It'll still happen, but thanks :D

Not sure if you saw the discussion on da-dev, but we added an allow list that won't show the warning on the commerce setup app. If you have any other apps to add to the list, let us know.

@sirugh
Copy link
Contributor

sirugh commented Dec 2, 2025

we added an allow list that won't show the warning on the commerce setup app

If it's per "site", then adobe-commerce/storefront-tools is sufficient.

@hannessolo hannessolo merged commit 9390b31 into main Dec 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants