Add ability to provide initial files to crawl #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
auniverseaway
approved these changes
Dec 9, 2025
Member
auniverseaway
left a comment
auniverseaway
left a comment
There was a problem hiding this comment.
I think "files" is probably misleading since its actually folders you want to traverse.
I would suggest:
- paths (as opposed to path)
- folders
My only argument against paths is that its so similar to path but that may be a feature... if someone does paths + string, we could convert to an array. Same for path... if they provide an array of paths to path we can upgrade it to an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for adobe/da-live#243
Previously crawl takes a root dir (path arg) and crawls everything within that dir and its children. Now we can provide an array of paths to crawl, as well as a list of files to also crawl.