Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-23453 Smart Crop auto rendition is broken with spaces in image… #2804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gubhatia
Copy link

@gubhatia gubhatia commented Jul 2, 2024

… name

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (b5e6a56) to head (515f82a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2804   +/-   ##
=========================================
  Coverage     87.21%   87.21%           
  Complexity     2687     2687           
=========================================
  Files           235      235           
  Lines          7170     7170           
  Branches       1096     1096           
=========================================
  Hits           6253     6253           
  Misses          363      363           
  Partials        554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gubhatia
Copy link
Author

gubhatia commented Jul 2, 2024

@bpauli Could you please review this change? Similar issue was fixed earlier - #2140 and looks like it got broken after - d291222

@gubhatia gubhatia changed the title ASSETS-40081 Smart Crop auto rendition is broken with spaces in image… SITES-23453 Smart Crop auto rendition is broken with spaces in image… Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant