UE: Support for fd:customDisplayFormat #1619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1619 +/- ##
============================================
+ Coverage 82.50% 82.51% +0.01%
- Complexity 1010 1011 +1
============================================
Files 108 108
Lines 2623 2625 +2
Branches 378 378
============================================
+ Hits 2164 2166 +2
Misses 270 270
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rismehta
reviewed
Jun 18, 2025
| @@ -165,6 +169,9 @@ public String getPlaceHolder() { | |||
| @Override | |||
| @Nullable | |||
| public String getDisplayFormat() { | |||
| if (customDisplayFormat != null) { | |||
There was a problem hiding this comment.
This is confusing, we already have displayFormat property for this, why do you need fd:customDisplayFormat ?
There was a problem hiding this comment.
@rismehta The property displayFormat is used for OOTB display formats and custom display formats, which does not allow us to support custom formats in UE. Therefore I have created a separate property just like for the Multiselect in dropdown PR
cc: @jalagari @ravise5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue being faced in UE as this PR
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: