UE: Support for fd:customDisplayFormat #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1619 +/- ##
============================================
+ Coverage 82.50% 82.51% +0.01%
- Complexity 1010 1011 +1
============================================
Files 108 108
Lines 2623 2625 +2
Branches 378 378
============================================
+ Hits 2164 2166 +2
Misses 270 270
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rismehta
reviewed
Jun 18, 2025
| @@ -165,6 +169,9 @@ public String getPlaceHolder() { | |||
| @Override | |||
| @Nullable | |||
| public String getDisplayFormat() { | |||
| if (customDisplayFormat != null) { | |||
There was a problem hiding this comment.
This is confusing, we already have displayFormat property for this, why do you need fd:customDisplayFormat ?
There was a problem hiding this comment.
@rismehta The property displayFormat is used for OOTB display formats and custom display formats, which does not allow us to support custom formats in UE. Therefore I have created a separate property just like for the Multiselect in dropdown PR
cc: @jalagari @ravise5
rismehta
requested changes
Jul 15, 2025
rismehta
reviewed
Jul 15, 2025
| @@ -165,6 +169,9 @@ public String getPlaceHolder() { | |||
| @Override | |||
| @Nullable | |||
| public String getDisplayFormat() { | |||
| if (customDisplayFormat != null) { | |||
There was a problem hiding this comment.
This property will only be present for EDS use-case, hence merging this. I don't think this would impact existing core component based form.
It might impact use-cases where EDS form is created using crispr json, which @TalmizAhmed can fix separately
rismehta
added a commit
that referenced
this pull request
Jul 17, 2025
* FORMS-18801: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn (#1632) Co-authored-by: Stefan Dragomir <[email protected]> * Fixing circle ci configuration (#1643) * feat: update token name and accesibility config (#1644) Co-authored-by: Prateek Awasthi <[email protected]> * FORMS-20749: Update af-core version to 0.22.143 (#1647) * Fixing adobe bot github token environment variable (#1646) * Support for fd:customDisplayFormat (#1619) * FORMS-18718: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn (#1631) * FORMS-18633: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn (#1630) * FORMS-20431: Update excludeFromDoRIfHidden prefix (#1617) * FORMS-20431: Update excludeFromDoRIfHidden prefix * FORMS-20431: Update test cases * FORMS-20431: Update the af-core version * FORMS-20431: Revert changes on package-lock.json --------- Co-authored-by: Rishi Mehta <[email protected]> * Forms-20262: FileInput v4 (#1618) * FORMS-20262: Handle invalid file attachments on client-side * add functionality to get collated alert message with multiple invalid errors * FORMS-20262: Update alert message content * FORMS-20262: Update alert message content * FORMS-20262: revert the fileinput base class to clean state * FORMS-20262: add size zero file error in error list * FORMS-20262: create fileinput v4 * checks for file size of 0 and throws error * collates all error messages in single alert * FORMS-20262: Update file input v4 readme * FORMS-20262: Update component version to v4 in readme * FORMS-20262: test cases for fileinput v4 * add collateral * create page for fileinput v4 * FORMS-20262: Update copyright year * FORMS-20262: fix resource super type * FORMS-20262: fix tracking feature for file input * FORMS-20262: add error message for zero-bytes file in all locale * FORMS-20262: mark head text as isHeading * FORMS-20262: pom replace fileinput v4 in libs * FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View (#1593) * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * updating crispr spec version in dialog * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion in formcontainerv2 * RTC Updated AdaptiveFormVersion in formcontainerv2WithAutoSave * Fixing code formatting --------- Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components (#1567) * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing synthetic resource changes * feat(print-properties): Adding test case for channel based fragment resolution * feat(print-properties): Removing the pageTemplate handling as it is not in separate PrintContainer * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding the change to resolve fragment based on its guideContainer in hierarchy * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Adding channel check while resolving fragment * feat(print-properties): Adding interfaces and model implementations * feat(print-properties): Moving print related model implementations in separate bundle * feat(print-properties): Updating schema version for more test files * feat(print-properties): RTC - Adding components - Barcode, Line and Rectangle * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): RTC - Adding UTs for print specific interfaces * feat(print-properties): Adding DoR view and correcting a typo * feat(print-properties): Adding more UTs * feat(print-properties): Removing print related files * feat(print-properties): Reformatting to avoid unnecessary changes * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing unnecessary file * feat(print-properties): Refactoring changes * feat(print-properties): Fixing issues with rebasing * feat(print-properties): Import sorting * feat(print-properties): Removing unnecessary file * feat(print-properties): Removing synthetic resource changes * feat(print-properties): Adding test case for channel based fragment resolution * feat(print-properties): Removing the pageTemplate handling as it is not in separate PrintContainer * feat(print-properties): Removing code came due to merge conflicts * feat(print-properties): Removing new schema; it is used in print specific sdk * feat(print-properties): Removing new field types * feat(print-properties): Updating version of dor api package * feat(print-properties): Converting string literals to constants * feat(print-properties): Adding test case for getDorContainer in the FormComponent inetrface * feat(print-cc): Adding changes to pass down channel info to correctly resolve fragment * feat(print-cc): Removing unnecessary change * feat(print-cc): Adding dorcontainer check in UT * feat(print-cc): Fixing conflict issues * feat(print-cc): Fixing conflict issues * feat(print-cc): Adding test cases for Views classes * feat(print-cc): Adding test case * FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View (#1593) * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * updating crispr spec version in dialog * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Adding Default specVersionfor formcontainerv2 test * Added fragment path in Crispr json for Author view * RTC Adding Default specVersionfor formcontainerv2 test * RTC updating test baseline * updated baseline * updating baseline * Added test cases and addressed review comments * RTC Removed duplicate function * RTC Updated AdaptiveFormVersion * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion or rest-submission * RTC Updated AdaptiveFormVersion in formcontainerv2 * RTC Updated AdaptiveFormVersion in formcontainerv2WithAutoSave * Fixing code formatting --------- Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * feat(print-cc): Updating version in test case --------- Co-authored-by: dhrsharm <[email protected]> Co-authored-by: vjystva <[email protected]> Co-authored-by: srivastv <[email protected]> Co-authored-by: Rishi Mehta <[email protected]> * Adding scribble signature support. (#1651) * Adding scribble signature support. * Adding scribble signature support. * Adding scribble signature support. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Moving the test logic to then post click. * Addressing review comments. * Moving the test logic to then post click. * Addressing review comments. * Addressing review comments. * Moving the test logic to then post click. * Fixing enter keydown event on forms (#1653) * link fix * Link fix * Fixing issue * FORMS-19721 Addition of rules to the CRISPR JSON for print channel (#1594) * Added rule events and passed chanel information to child * Added rule events and passed chanel information to child * Removed unnecessary imports * Removed rule editor uber changes * mergedchanges and added missing one * mergedchanges and added missing one * Added test cases * modified null check * Empty value (#1654) * Empty value fix * Empty value fix * Adding test cases * Fixing package info * feat: token name updated (#1652) Co-authored-by: Prateek Awasthi <[email protected]> * Fixing token * Resolving merge conflicts --------- Co-authored-by: Stefan Dragomir <[email protected]> Co-authored-by: Stefan Dragomir <[email protected]> Co-authored-by: Prateek Awasthi <[email protected]> Co-authored-by: Prateek Awasthi <[email protected]> Co-authored-by: anshikag-adobe <[email protected]> Co-authored-by: Talmiz Ahmed <[email protected]> Co-authored-by: CezarSTF <[email protected]> Co-authored-by: vjystva <[email protected]> Co-authored-by: srivastv <[email protected]> Co-authored-by: DhruvSharma-845 <[email protected]> Co-authored-by: dhrsharm <[email protected]> Co-authored-by: sakshi-arora1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue being faced in UE as this PR
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: