Skip to content

FORMS-20431: Update excludeFromDoRIfHidden prefix #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

FORMS-20431: Update excludeFromDoRIfHidden prefix #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87a5387
FORMS-20431: Update excludeFromDoRIfHidden prefix
anshikag-adobe Jun 11, 2025
38950fa
FORMS-20431: Update test cases
anshikag-adobe Jun 11, 2025
67d4a35
FORMS-20431: Update the af-core version
anshikag-adobe Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...re/src/main/java/com/adobe/cq/forms/core/components/internal/form/ReservedProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ private ReservedProperties() {
public static final String FD_ENABLE_AUTO_SAVE = "fd:enableAutoSave";
public static final String FD_AUTO_SAVE_STRATEGY_TYPE = "fd:autoSaveStrategyType";
public static final String FD_AUTO_SAVE_INTERVAL = "fd:autoSaveInterval";
public static final String FD_EXCLUDE_FROM_DOR_IF_HIDDEN = "excludeFromDoRIfHidden";
public static final String FD_EXCLUDE_FROM_DOR_IF_HIDDEN = "fd:excludeFromDoRIfHidden";

public static final String FD_XFA_SCRIPTS = "fd:xfaScripts";

Expand Down
2 changes: 1 addition & 1 deletion ...in/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ public Map<String, Object> getDorProperties() {
customDorProperties.put(DOR_TEMPLATE_TYPE, dorTemplateType);
}
if (excludeFromDoRIfHidden != null) {
customDorProperties.put(EXCLUDE_FROM_DOR_IF_HIDDEN, excludeFromDoRIfHidden);
customDorProperties.put(ReservedProperties.FD_EXCLUDE_FROM_DOR_IF_HIDDEN, excludeFromDoRIfHidden);
}
return customDorProperties;
}
Expand Down
8 changes: 4 additions & 4 deletions ...ava/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,8 +798,8 @@ void testExcludeFromDoRIfHiddenFromViewPrint() throws Exception {

FormContainer formContainer = Utils.getComponentUnderTest(PATH_FORM_EXCLUDE_FROM_DOR_IF_HIDDEN, FormContainer.class, context);
Map<String, Object> dorProperties = ((FormContainerImpl) formContainer).getDorProperties();
assertTrue(dorProperties.containsKey("excludeFromDoRIfHidden"));
assertEquals(true, dorProperties.get("excludeFromDoRIfHidden"));
assertTrue(dorProperties.containsKey("fd:excludeFromDoRIfHidden"));
assertEquals(true, dorProperties.get("fd:excludeFromDoRIfHidden"));
}

@Test
Expand All @@ -812,7 +812,7 @@ void testExcludeFromDoRIfHiddenFromViewPrintFalse() throws Exception {

FormContainer formContainer = Utils.getComponentUnderTest(PATH_FORM_EXCLUDE_FROM_DOR_IF_HIDDEN, FormContainer.class, context);
Map<String, Object> dorProperties = ((FormContainerImpl) formContainer).getDorProperties();
assertTrue(dorProperties.containsKey("excludeFromDoRIfHidden"));
assertEquals(false, dorProperties.get("excludeFromDoRIfHidden"));
assertTrue(dorProperties.containsKey("fd:excludeFromDoRIfHidden"));
assertEquals(false, dorProperties.get("fd:excludeFromDoRIfHidden"));
}
}
33 changes: 17 additions & 16 deletions ui.frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ui.frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
"webpack-merge": "^5.8.0"
},
"dependencies": {
"@aemforms/af-core": "^0.22.129",
"@aemforms/af-core": "^0.22.134",
"@aemforms/af-core-xfa": "^0.1.6",
"@aemforms/af-formatters": "^0.22.129",
"@aemforms/af-formatters": "^0.22.134",
"@aemforms/af-custom-functions": "1.0.15"
}
}
Loading