Skip to content

FORMS-18771: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

FORMS-18771: Desktop, RWD Tablet, RWD Mobile - Visual heading text is not marked as heading @sunnym @vavarshn #1608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/content/jcr_root/apps/core/fd/components/form/tabsontop/v1/tabsontop/tabsontop.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
data-cmp-adaptiveformcontainer-path="${formstructparser.formContainerPath}"
data-placeholder-text="${wcmmode.edit && 'Please drag Tab components here' @ i18n}"
data-sly-test.widgetId="${'{0}-{1}' @ format=[panel.id, 'widget']}">
<div class="cmp-tabs__label-container">
<div class="cmp-tabs__label-container" role="heading">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are adding the role="heading" attribute, you must also include the aria-level="1" to aria-level="6" attribute, depending on the appropriate heading level required. In this scenario, we should add aria-level="2".

<div data-sly-call="${label.label @componentId=widgetId, labelValue=panel.label.value, labelVisible=panel.label.visible, labelRichText=panel.label.richText, bemBlock='cmp-tabs'}" data-sly-unwrap></div>
<div data-sly-call="${questionMark.questionMark @componentId=panel.id, longDescription=panel.description, bemBlock='cmp-tabs'}" data-sly-unwrap></div>
</div>
Expand Down
Loading