Fieldset Legend in Checkboxgroup #1606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-18211
branch
from
d81d381 to
0d3d221
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1606 +/- ##
=========================================
Coverage 82.50% 82.50%
Complexity 1010 1010
=========================================
Files 108 108
Lines 2623 2623
Branches 378 378
=========================================
Hits 2164 2164
Misses 270 270
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
force-pushed
the
FORMS-18211
branch
from
746e19b to
e700597
Compare
anshikag-adobe
approved these changes
Jul 11, 2025
rismehta
reviewed
Jul 15, 2025
| data-sly-use.questionMark="${renderer.questionMarkPath}"></sly> | ||
|
|
||
|
|
||
| <fieldset class="cmp-adaptiveform-checkboxgroup cmp-adaptiveform-checkboxgroup--v2" |
There was a problem hiding this comment.
We don't add --v2 in the suffix for the version
There was a problem hiding this comment.
but rishi, if we need to make any changes in css then how it will be implemented on this version
rismehta
reviewed
Jul 15, 2025
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Please update component readme to include the exact changes, also update the BEM as per the new HTML in the component readme
|
You also need to update this section here, https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/pom.xml#L341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: