Date time input field #1587

devgurjar · 2025-05-14T09:55:17Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

codecov · 2025-05-21T06:38:50Z

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (f268f3e) to head (c233a95).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...mponents/internal/models/v1/form/DateTimeImpl.java	94.44%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1587      +/-   ##
============================================
+ Coverage     82.79%   82.87%   +0.08%     
- Complexity     1036     1047      +11     
============================================
  Files           109      110       +1     
  Lines          2697     2716      +19     
  Branches        392      394       +2     
============================================
+ Hits           2233     2251      +18     
  Misses          270      270              
- Partials        194      195       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

adobe-bot · 2025-05-21T06:52:28Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-05-21T06:52:28Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-05-21T06:52:39Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-21T06:53:03Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-21T06:53:44Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-21T07:41:59Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-05-21T07:41:59Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-05-21T07:42:09Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-05-21T07:42:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-21T07:42:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-22T05:57:47Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-05-22T05:57:47Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2025-05-22T05:57:57Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-22T05:58:32Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-05-22T05:59:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-22T06:55:10Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2025-05-22T06:55:10Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-05-22T06:55:20Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-22T06:56:13Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-05-22T06:56:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta · 2025-07-16T10:10:44Z

bundles/af-core/src/test/java/com/adobe/cq/forms/core/Utils.java

@@ -152,7 +152,7 @@ public static void testSchemaValidation(@NotNull Object model) {
                ((ObjectNode) formContainerTemplateNode).putArray("items").add(json);
                json = formContainerTemplateNode;
            }
-            // create set of validation message and store result in it
+            // create set of validation message and st ore result in it


Fix this typo

rismehta · 2025-07-16T10:10:55Z

bundles/af-core/src/test/resources/schema/0.14.2/adaptive-form.schema.json

Please remove these changes

Removed, I think this was the culprit, these changes were added by Intellij automatically.

rismehta · 2025-07-16T10:12:03Z

bundles/af-core/src/test/resources/form/formcontainer/test-page-content.json

@@ -94,7 +94,7 @@
      ],
      "fd:version": "2.1",
      "schemaType": "none",
-      "specVersion": "0.14.2",
+      "specVersion": "0.15.2",


Why did you make this change ?

Please don't make any changes in the file which is not related to this PR

If I am not updating this version, 3 tests are failing FormContainerImplTest.testJSONExportWithoutSubmissionAttribute
FormContainerImplTest.testJSONExportWithSubmissionHeader
FormContainerImplTest.testJSONExportWithSubmissionAttribute

rismehta · 2025-07-16T10:13:12Z

...test/resources/form/formcontainer/exporter-formContainer-ue-form-spreadsheet-submission.json

Please remove these changes from this PR

rismehta · 2025-07-16T10:13:30Z

ui.tests/test-module/package-lock.json

@@ -4150,7 +4150,7 @@
      "integrity": "sha512-qeFIXtP4MSoi6NLqO12WfqARWWuCKi2Rn/9hJLEmtB5yTNr9DqFWkJRCf2qShWzPeAMRnOgCrq0sg/KLv5ES9w==",
      "dev": true,
      "dependencies": {
-        "tweetnacl": "^0.14.3"
+        "tweetnacl": "^0.15.0"


Please remove these changes

rismehta · 2025-07-16T13:30:38Z

...-core/src/main/java/com/adobe/cq/forms/core/components/internal/form/ReservedProperties.java

@@ -85,6 +85,9 @@ private ReservedProperties() {
    public static final String PN_MAX_LENGTH = "maxLength";
    public static final String PN_MINIMUM_DATE = "minimumDate";
    public static final String PN_MAXIMUM_DATE = "maximumDate";
+    public static final String PN_MINIMUM_DATE_TIME = "minimumDateTime";
+    public static final String PN_DEFAULT_DATE_TIME = "defaultDateTime";


Why is this not yet removed, this is not used anywhere

rismehta · 2025-07-16T13:31:25Z

Please resolve conflicts

rismehta

I don't see authoring or runtime test cases for date time component

adobe-bot · 2025-07-17T12:20:51Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-07-17T12:21:42Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-07-17T13:12:27Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2025-07-17T13:15:14Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

devgurjar · 2025-07-17T13:49:48Z

I don't see authoring or runtime test cases for date time component

I have added tests

@releng

* Date time input field (#1587) * date time input field * date time fixes * Added test cases * fixed default message issue * fixed formatting * fixing code coverage * removed css and fixed formatting * Incorporated review comments * Added cypress tests on authoring and runtime --------- Co-authored-by: dgurjar <[email protected]> * @releng updating af-core (#1657) --------- Co-authored-by: Devendra Gurjar <[email protected]> Co-authored-by: dgurjar <[email protected]>

devgurjar force-pushed the dateTimeInputField branch from 3b68bf0 to 3b715a4 Compare May 14, 2025 10:14

github-actions bot force-pushed the dateTimeInputField branch from 3783f6f to 7721b87 Compare May 20, 2025 10:42

devgurjar force-pushed the dateTimeInputField branch from 7721b87 to 9f69daf Compare May 21, 2025 04:29

github-actions bot force-pushed the dateTimeInputField branch from 9f69daf to 134d77a Compare May 21, 2025 04:29

devgurjar force-pushed the dateTimeInputField branch from 134d77a to 0e41af4 Compare May 21, 2025 06:28

github-actions bot force-pushed the dateTimeInputField branch from 0e41af4 to 2527241 Compare May 21, 2025 06:28

devgurjar force-pushed the dateTimeInputField branch from 2527241 to 68c79c4 Compare May 22, 2025 05:35

github-actions bot force-pushed the dateTimeInputField branch from 68c79c4 to 0471057 Compare May 22, 2025 05:35

devgurjar force-pushed the dateTimeInputField branch from 0471057 to 314d9c9 Compare May 22, 2025 09:51

devgurjar force-pushed the dateTimeInputField branch from 62aa4b5 to 33654cb Compare July 16, 2025 09:36

rismehta reviewed Jul 16, 2025

View reviewed changes

devgurjar force-pushed the dateTimeInputField branch 2 times, most recently from cb379de to 857e253 Compare July 16, 2025 12:50

rismehta reviewed Jul 16, 2025

View reviewed changes

devgurjar force-pushed the dateTimeInputField branch from 857e253 to e1d2e3b Compare July 16, 2025 13:37

rismehta requested changes Jul 16, 2025

View reviewed changes

dgurjar added 9 commits July 17, 2025 17:18

date time input field

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

5180e83

date time fixes

b9a80d0

Added test cases

2285f37

fixed default message issue

cd96d8b

fixed formatting

df3aa3a

fixing code coverage

536123e

removed css and fixed formatting

99dfeab

Incorporated review comments

e9a28c5

Added cypress tests on authoring and runtime

Loading
Loading status checks…

c233a95

devgurjar force-pushed the dateTimeInputField branch from e1d2e3b to c233a95 Compare July 17, 2025 11:49

rismehta merged commit f74d2c6 into dev Jul 18, 2025
11 checks passed

rismehta deleted the dateTimeInputField branch July 18, 2025 09:48

Date time input field #1587

Date time input field #1587

Conversation

devgurjar commented May 14, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

codecov bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adobe-bot commented May 21, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented May 21, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 21, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented May 21, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 21, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented May 22, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented May 22, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented May 22, 2025

Accessibility Violations Found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 21, 2025 •

edited

Loading