Skip to content

Forms 18927 allow extensions support in file input #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

rajatofficial
Copy link
Contributor

No description provided.

@rajatofficial rajatofficial changed the base branch from master to dev May 7, 2025 05:07
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (1ec18f1) to head (c10b1e9).

Files with missing lines Patch % Lines
...q/forms/core/components/models/form/FileInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1586      +/-   ##
============================================
+ Coverage     82.32%   82.34%   +0.01%     
- Complexity     1000     1004       +4     
============================================
  Files           108      108              
  Lines          2603     2611       +8     
  Branches        370      371       +1     
============================================
+ Hits           2143     2150       +7     
- Misses          272      273       +1     
  Partials        188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rajatofficial rajatofficial force-pushed the FORMS-18927-AllowExtensionsSupportInFileInput branch from 920a278 to c10b1e9 Compare May 7, 2025 09:46
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants