FORMS-18634: Desktop, RWD Tablet, RWD Mobile - Form field with error not identified @sunnym @vavarshn #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not identified @sunnym @vavarshn
| @@ -1,3 +1,3 @@ | |||
| <template data-sly-template.errorMessage="${@ componentId, bemBlock}"> | |||
| <div class="${bemBlock}__errormessage" id="${componentId}__errormessage" aria-live="assertive"></div> | |||
| <div class="${bemBlock}__errormessage" id="${componentId}__errormessage" aria-live="assertive" tabindex=0 role="complementary"></div> | |||
There was a problem hiding this comment.
tabindex needs to be set dynamically, depending on error at runtime on field, if there is no error then it should be -1
There was a problem hiding this comment.
Will revert this file to original and update the logic in FormFieldBase.js
amit-mnnit
reviewed
Jun 17, 2025
| @@ -176,6 +177,7 @@ class FormFieldBase extends FormField { | |||
| let errorElement = typeof this.getErrorDiv === 'function' ? this.getErrorDiv() : null; | |||
| if (errorElement) { | |||
| errorElement.setAttribute('id', `${this.getId()}__errormessage`); | |||
| errorElement.setAttribute('aria-describedby', `${this.getId()}__label`); | |||
There was a problem hiding this comment.
It is already present in the input field. We can not use the aria-describedby attribute on the error container.
amit-mnnit
reviewed
Jun 17, 2025
| @@ -167,6 +167,7 @@ class FormFieldBase extends FormField { | |||
| #syncLabel() { | |||
| let labelElement = typeof this.getLabel === 'function' ? this.getLabel() : null; | |||
| if (labelElement) { | |||
| labelElement.setAttribute('id', `${this.getId()}__label`); | |||
amit-mnnit
reviewed
Jun 17, 2025
| @@ -550,7 +554,9 @@ class FormFieldBase extends FormField { | |||
| if (!state.validationMessage) { | |||
| this.errorDiv.innerHTML = LanguageUtils.getTranslatedString(this.formContainer.getModel().lang, "defaultError"); | |||
| } | |||
| } | |||
| this.errorDiv.setAttribute('tabindex', 0); | |||
| this.errorDiv.setAttribute('role', 'complementary'); | |||
There was a problem hiding this comment.
It is usually incorrect to use role="complementary" on an error container.
Use role="alert" or aria-live="assertive" for error messages, as this is the best practice(Optional)
amit-mnnit
requested changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
https://jira.corp.adobe.com/browse/FORMS-18634
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: