FORMS-18739: Visual heading text is not marked as heading #1574
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ | |||
| data-cmp-single-expansion="true" | |||
| data-placeholder-text="${wcmmode.edit && 'Please drag Accordion item components here' @ i18n}"> | |||
|
|
|||
| <div class="cmp-accordion__label-container"> | |||
| <div class="cmp-accordion__label-container" role="heading" aria-level="2"> | |||
There was a problem hiding this comment.
aria-level 2, can't be there, as it could be inside another container
10 tasks
amit-mnnit
reviewed
Jun 17, 2025
| @@ -29,7 +29,7 @@ | |||
| data-cmp-single-expansion="true" | |||
| data-placeholder-text="${wcmmode.edit && 'Please drag Accordion item components here' @ i18n}"> | |||
|
|
|||
| <div class="cmp-accordion__label-container"> | |||
| <div class="cmp-accordion__label-container" role="heading"> | |||
There was a problem hiding this comment.
If you are adding the role="heading" attribute, you must also include the aria-level="1" to aria-level="6" attribute, depending on the appropriate heading level required. In this scenario, we should add aria-level="2".
There was a problem hiding this comment.
Hello @amit-mnnit ! @sakshi-arora1 told me to only add role="heading" because aria-level can't be predicted.
amit-mnnit
requested changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: