FORMS-18684: Function cannot be performed by keyboard alone @sunnym @vavarshn #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,8 @@ | |||
| errorDiv: `.${CheckBoxGroup.bemBlock}__errormessage`, | |||
| tooltipDiv: `.${CheckBoxGroup.bemBlock}__shortdescription`, | |||
| item: `.${CheckBoxGroup.bemBlock}-item`, | |||
| optionLabel: `${CheckBoxGroup.bemBlock}__option-label` | |||
| optionLabel: `${CheckBoxGroup.bemBlock}__option-label`, | |||
| optionLink: `${CheckBoxGroup.bemBlock}__links` | |||
There was a problem hiding this comment.
This is only there for toggelable link, its not there for checboxgroup
There was a problem hiding this comment.
Correct, I added it there to keep consistent with the code style.
amit-mnnit
reviewed
Jul 11, 2025
| let optionLinks = this.element.querySelectorAll(`.${CheckBoxGroup.selectors.optionLink}`); | ||
| optionLinks.forEach(optionLink => { | ||
| optionLink.addEventListener('keydown', (e)=>{ | ||
| if(e.key === 'Enter' || e.key ===' ') { |
There was a problem hiding this comment.
Create a variable for the list ['Enter', ' ', 'Spacebar', 'Space'] and use it wherever needed. Please update it in the link below.
#1591 (comment)
amit-mnnit
requested changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
https://jira.corp.adobe.com/browse/FORMS-18684
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: