Skip to content

Scribble component #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Scribble component #1569

wants to merge 18 commits into from
+1,880 −6

Conversation

rajatofficial
Copy link
Contributor

No description provided.

@rajatofficial
Copy link
Contributor Author

WIP, Looking for early feedback.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (945972f) to head (25d1051).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...mponents/internal/models/v1/form/ScribbleImpl.java 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #1569      +/-   ##
============================================
- Coverage     82.32%   82.10%   -0.23%     
  Complexity     1000     1000              
============================================
  Files           108      109       +1     
  Lines          2603     2610       +7     
  Branches        370      371       +1     
============================================
  Hits           2143     2143              
- Misses          272      279       +7     
  Partials        188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavi41 pavi41 force-pushed the scribble-component branch from 2ece48e to f8538c1 Compare May 7, 2025 06:21
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

sakshi-arora1
sakshi-arora1 reviewed May 15, 2025
View reviewed changes
...f.apps/src/main/content/jcr_root/apps/core/fd/components/form/scribble/v1/scribble/README.md Outdated
            ELEMENT cmp-adaptiveform-scribble__clearsign-content
                ELEMENT cmp-adaptiveform-scribble__clearsign-message
                ELEMENT cmp-adaptiveform-scribble__clearsign-panel
                    ELEMENT cmp-adaptiveform-scribble__clearsign-cancel-button cmp-adaptiveform-scribble__button--secondary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use only one class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change this

sakshi-arora1
sakshi-arora1 reviewed May 15, 2025
View reviewed changes
...f.apps/src/main/content/jcr_root/apps/core/fd/components/form/scribble/v1/scribble/README.md
            ELEMENT cmp-adaptiveform-scribble__controlpanel
                ELEMENT cmp-adaptiveform-scribble__controls
                    ELEMENT cmp-adaptiveform-scribble__control-brush
                        MODIFIER cmp-adaptiveform-scribble__button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a modifier?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this same for all controls?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

sakshi-arora1
sakshi-arora1 reviewed May 15, 2025
View reviewed changes
...f.apps/src/main/content/jcr_root/apps/core/fd/components/form/scribble/v1/scribble/README.md
                    ELEMENT cmp-adaptiveform-scribble__control-text
                        MODIFIER cmp-adaptiveform-scribble__button
                    ELEMENT cmp-adaptiveform-scribble__control-message
                ELEMENT cmp-adaptiveform-scribble__controlpanel__controls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have ELEMENT cmp-adaptiveform-scribble__controlpanel
ELEMENT cmp-adaptiveform-scribble__controls
and ELEMENT cmp-adaptiveform-scribble__controlpanel__controls as separate entities?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

sakshi-arora1
sakshi-arora1 reviewed May 15, 2025
View reviewed changes
...f.apps/src/main/content/jcr_root/apps/core/fd/components/form/scribble/v1/scribble/README.md
                    ELEMENT cmp-adaptiveform-scribble__control-message
                ELEMENT cmp-adaptiveform-scribble__controlpanel__controls
                    ELEMENT cmp-adaptiveform-scribble__button-close
                    ELEMENT cmp-adaptiveform-scribble__save-button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep consistent either button pre-appended or appended across items

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakshi-arora1 sakshi-arora1 sakshi-arora1 requested changes

@pavi41 pavi41 pavi41 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajatofficial @adobe-bot @sakshi-arora1 @pavi41 @rajatkhurana-adobe @devgurjar