FORMS-18673: Visual heading text is not marked as heading @sunnym @vavarshn #1563
Conversation
|
|
||
| const bemClass = Array.from(this.element.classList).filter(bemClass => !bemClass.includes('--'))[0]; | ||
| if (bemClass && this.label.parentElement.classList.contains(`${bemClass}__label-container`)) { | ||
| this.label.setAttribute(Constants.ROLE, "heading"); |
There was a problem hiding this comment.
role="heading" is not required on a label container. Labels are already accessible using the for attribute and the corresponding id.
| const bemClass = Array.from(this.element.classList).filter(bemClass => !bemClass.includes('--'))[0]; | ||
| const labelContainer = this.element.querySelector(`.${bemClass}__label-container`); | ||
| if (labelContainer) { | ||
| labelContainer.querySelector("label").setAttribute(Constants.ROLE, "heading"); |
There was a problem hiding this comment.
role="heading" is not required on a label container. Labels are already accessible using the for attribute and the corresponding id.
|
Hello @amit-mnnit ! Also, the description of FORMS-18673 suggests this fix: In the description, you can also find these reference links: Please review and let me know if the fix is fine. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: