Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeinstancesufo] keep all public lib keys in instances #1747

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

arialcrime
Copy link
Contributor

@arialcrime arialcrime commented Jun 19, 2024

Description

This slightly alters the behaviour of makeinstancesufo’s postProcessInstance. clearCustomLibs now keeps all lib keys that start with public..

fixes #1746

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me

@arialcrime
Copy link
Contributor Author

Not very experienced with these tests, but it seems like the hiccup in “C and Python coverage / coverage (pull_request)” is not related to my changes, right?

@skef skef merged commit 8f47516 into adobe-type-tools:develop Jul 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[makeinstancesufo] allow public.skipExportGlyphs in instances
2 participants