remove PUA code points from resource files #1712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon a rebuild of the FDK, this should probably address #1662.
|
I guess this means that some of the expected CJK fonts contain PUA glyphs :-) |
No — these test failures are caused by a change in fontTools v4.43.0, unrelated to your changes around removing PUAs. |
|
@frankrolf once #1715 is merged, rebase this and it should pass. I'm still not convinced of the need to change AGD.txt but I guess it makes sense to keep its contents in sync with what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon a rebuild of the FDK, this should probably address #1662.
Description
This commit is deleting any glyph name associated with a PUA code points from AGD.txt, and (probably more importantly) agl2uv.h.
The assumption is that
makeotfexewill no longer unexpectedly assign PUA code points.I don’t have a way to test this locally (or I don’t know) – would be curious to figure out what the next steps are.