Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types setting from pull_request #1664

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

miguelsousa
Copy link
Member

Removes the types setting from pull_request section of workflow files.

This setting was originally added to prevent the CI from triggering twice (on push and on pull-request) with each commit to a branch with an opened PR. The current workflow configuration works fine for developers that have privileges to push branches to the repo, but it has the adverse side-effect of getting the CI stuck on PRs from forks, if the external developer makes commits to their branches after the PR has been opened.

I've made this same change on another project and I'm only seeing duplicate CI runs on one kind of event: when the PR is opened. After that, all commits to the branch only trigger pull_request CI runs (and not push CI runs).

@miguelsousa
Copy link
Member Author

Adding concurrency didn't make a difference. The CI runs are still triggering on both push and pull_request events. 😖
dups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant