Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirements.txt] change fontTools version from '<=' to '==' #1661

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Jun 8, 2023

to accept more versions.
Should fix #1660

Description

  • currently, setup.py changes '==' to '>=' but we had set fontTools to '<=' due to an earlier issue where we had to pin the version number. We no longer need to pin the version number, so we're changing it back to '=='.
  • as Miguel mentioned, we should add support for more string replacement cases in setup.py — I'll look at that in a few days, but pushing this PR first to get a pre-release out for issue AFDKO 3.9.5 incompatible with FontTools > 4.39.3. Any plans to support FontTools 4.39.4? #1660 .

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kaydeearts kaydeearts merged commit d4a0bdd into develop Jun 8, 2023
15 checks passed
@kaydeearts kaydeearts deleted the kd-fix-requirements branch June 8, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AFDKO 3.9.5 incompatible with FontTools > 4.39.3. Any plans to support FontTools 4.39.4?
2 participants