Add streaming command support. #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrouesnel
force-pushed
the
streaming_responses
branch
3 times, most recently
from
807e96a to
1991a12
Compare
wrouesnel
changed the title
|
Nice, I'll have to take some time to review the refactor changes you made to the |
gamefundas
approved these changes
Sep 26, 2018
|
We have approval, so can we have it merged, @adnanh @wrouesnel ? |
wrouesnel
force-pushed
the
streaming_responses
branch
from
1991a12 to
12b93fd
Compare
Add options - `stream-stdout-in-response` - `stream-stdout-in-response-on-error` - `stream-command-kill-grace-period-seconds` to allow defining webhooks which dynamically stream large content back to the requestor. This allows the creation of download endpoints from scripts, i.e. running a `git archive` command or a database dump from a docker container, without needing to buffer up the original.
wrouesnel
force-pushed
the
streaming_responses
branch
from
12b93fd to
08fc28b
Compare
|
A long overdue rebase and merge! |
Closed
|
I would really appreciate this feature in CI/CD. Is it possible to review and merge this, since it seems to be implemented already 🙏 Thanks a lot for your work 👍 |
|
I don't know if Adnan will be looking at this any time soon but just as an FYI for the PR author, this is now conflicting again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #250.
Add options
stream-stdout-in-responsestream-stdout-in-response-on-errorstream-command-kill-grace-period-secondsto allow defining webhooks which dynamically stream large content back to the
requestor. This allows the creation of download endpoints from scripts, i.e.
running a
git archivecommand or a database dump from a docker container,without needing to buffer up the original.
Notes
This includes a refactor and clean up
hookHandlerto be somewhat more linear then the original was due to the added complexity of handling the deferred behavior of command streaming.