feat(visually-hidden): added asChild prop to VisuallyHidden #2554
Conversation
Powerplex
force-pushed
the
visually-hidden-aschild
branch
from
08c278b to
1c2b96d
Compare
| @@ -23,6 +23,9 @@ | |||
| "scripts": { | |||
| "build": "vite build" | |||
| }, | |||
| "dependencies": { | |||
| "@spark-ui/slot": "^8.0.2" | |||
There was a problem hiding this comment.
| "@spark-ui/slot": "^8.0.2" | |
| "@spark-ui/slot": "8.0.2" |
There was a problem hiding this comment.
Are you sure ? This is like this in every package.
Enregistrement.de.l.ecran.2025-01-16.a.10.19.24.mov
There was a problem hiding this comment.
That should not be the case imho, as it may introduce different users with varying versions of those dependencies installed on their machines, making it difficult to debug in the event of bugs.
See 👉https://github.com/adevinta/spark/wiki/Agreements#managing-dependencies-within-spark-components
There was a problem hiding this comment.
Are you ok if I replace everywhere then but in a separate PR ? I have a feeling that we used to remove the ^ in the past and that it is possibly the fixed versioning that automatically added it back everywhere ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
=======================================
Coverage 96.50% 96.50%
=======================================
Files 520 520
Lines 4610 4611 +1
Branches 1621 1622 +1
=======================================
+ Hits 4449 4450 +1
Misses 159 159
Partials 2 2 ☔ View full report in Codecov by Sentry. |
TASK: SPA-485
Description, Motivation and Context
Missing
asChildprop onVisuallyHiddento make it polymorphic. Until now it was aspanand could not be any other html tag.Types of changes