Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): Component tha use material color token would be transaprent #1311

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

soulcramer
Copy link
Contributor

@soulcramer soulcramer commented Sep 25, 2024

📋 Changes

The color for Material tcolor tokens for the new surfaces were using Unspecified which would make them transparent in Dialog for ex.

🤔 Context

These colors were added with the version upgrade of Material 3 to 1.3.0

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.

The color for Material tcolor tokens for the new surfaces were using Unspecified which would make them transparent in Dialog for ex.
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix colors from materila upgrade"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@soulcramer soulcramer changed the title Fix colors from materila upgrade fix(color): Component tha use material color token would be transaprent Sep 25, 2024
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew cleanRecordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link
Contributor

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.10.1 Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.10.1 Build Scan not published

@soulcramer soulcramer merged commit 937c4d1 into main Sep 25, 2024
6 checks passed
@soulcramer soulcramer deleted the Fix-colors-from-materila-upgrade branch September 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants