Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test adding support for animated icons #1285

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: test adding support for animated icons #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41c656f
feat: test adding support for animated icons
soulcramer Sep 6, 2024
6968621
Apply spotless
soulcramer Sep 10, 2024
cfd8db9
GitButler WIP Commit
gitbutler-client Oct 2, 2024
7a4fbac
Fixes for compose 1.7
soulcramer Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...rc/main/kotlin/com/adevinta/spark/catalog/examples/samples/buttons/IconButtonsExamples.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ import com.adevinta.spark.components.iconbuttons.IconButtonFilled
import com.adevinta.spark.components.iconbuttons.IconButtonGhost
import com.adevinta.spark.components.iconbuttons.IconButtonOutlined
import com.adevinta.spark.components.iconbuttons.IconButtonTinted
import com.adevinta.spark.icons.LikeFill
import com.adevinta.spark.icons.BellShake
import com.adevinta.spark.icons.SparkAnimatedIcons
import com.adevinta.spark.icons.SparkIcon
import com.adevinta.spark.icons.SparkIcons

private const val IconButtonsExampleDescription = "Icon Button examples"
private const val IconButtonsExampleSourceUrl = "$SampleSourceUrl/IconButtonSamples.kt"
Expand All @@ -56,6 +56,7 @@ public val IconButtonsExamples: List<Example> = listOf(
icon = icon,
contentDescription = contentDescription,
isLoading = isLoading,
atEnd = false,
)
},
)
Expand Down Expand Up @@ -143,7 +144,7 @@ private fun IconButtonSample(
Column(
verticalArrangement = Arrangement.spacedBy(16.dp),
) {
val icon = SparkIcons.LikeFill
val icon = SparkAnimatedIcons.BellShake
val contentDescription = "Localized Content Description"
val isLoading by remember { mutableStateOf(false) }
button(
Expand Down
Loading
Loading