Return the MCP columns to GPA0-5 #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts 345b7ef . There had been a note that the columns actually went from INTA-GPA5. That's not right--although the firmware does write INTA during column operations, it's a control register, _not_ an I/O pin.
|
Wait, don't merge this yet. It accidentally brings back column 6 (the ergodox's innermost column). |
ErinCall
changed the title
|
OK, fixed that problem! This is ready to go. |
mostley
referenced
this pull request
in mostley/blender-dactyl-keyboard
Nov 14, 2021
Fix json upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts 345b7ef (#43).
There had been a note that the columns actually went from INTA-GPA5. That's not right--although the firmware does write INTA during column operations, it's a control register, not an I/O pin.