-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor authentication #676
Open
virgo075
wants to merge
914
commits into
addyosmani:labs
Choose a base branch
from
virgo075:refactor-authentication
base: labs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spelling and Grammar in Chapters 7, 8, and 9
Also a typo correction in Chapter 14.
Conflicts: chapters/08-extensions.md
Chapter 8: Extensions - Some rewording and corrections
…ng issues will need to be updated to reflect this.
A lot of small corrections for the second half of the book.
Merged my corrections and rewording with latest.
Fixed example which references non existent model "todo" instead of "todo1". Fixed minor typos.
Changed window.app.* to app.* to match the example code.
Add missing space between Ajax and (Asynchronous JavaScript and XML)
use the correct "its"
s/the QUnit/QUnit/
fixed spelling of independent
Fixed two typos
Corrected a wrong reference.
Simple typo correction in the Introduction
Fixed Marionette's class name in TodoMVC example
More type="text/javascript" removed
…n array, fixed router to work with optional items
…t coma in array, fixed router to work with optional items" This reverts commit 4d1a704.
Changed window.app.* to app.* to match the example code in Example 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gfd