Skip to content

fix: ignore url not configured when use mock adapters #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bokelley merged 1 commit into from
Jan 24, 2026
Merged

fix: ignore url not configured when use mock adapters #943

bokelley merged 1 commit into from
Jan 24, 2026
+9 −9

Conversation

@roofeel-fm
Copy link
Contributor

@roofeel-fm roofeel-fm commented Jan 8, 2026 •
edited
Loading

  • Moved agent URL retrieval after the auto-verification block
  • This allows the function to return early with auto-verified results for mock/dev environments
  • Only production tenants with real adapters need the agent URL for actual adagents.json verification
  • Prevents "Agent URL not configured" errors when using mock adapters in testing scenarios

EmmaLouise2018
EmmaLouise2018 approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@EmmaLouise2018 EmmaLouise2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically makes sense. Looks like some of the test suite does need to be updated to accommodate the new logic

@roofeel-fm roofeel-fm force-pushed the fix/ignore-url-not-configured-when-use-adapters branch from aa2e0c5 to 57ad9a0 Compare January 12, 2026 08:13
@roofeel-fm roofeel-fm force-pushed the fix/ignore-url-not-configured-when-use-adapters branch from 57ad9a0 to 4f8588d Compare January 14, 2026 23:57
@roofeel-fm
Copy link
Contributor Author

roofeel-fm commented Jan 15, 2026

Hi @EmmaLouise2018 , all pass since rebase the 0.8.0 version

@bokelley bokelley merged commit 7f55e02 into adcontextprotocol:main Jan 24, 2026
13 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmaLouise2018 EmmaLouise2018 EmmaLouise2018 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roofeel-fm @EmmaLouise2018 @bokelley